Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update controller logic to include single node selection with prefix #22

Merged

Conversation

kshave
Copy link
Contributor

@kshave kshave commented Aug 9, 2024

Description

Please provide a meaningful description of what this change will do, or is for. Bonus points for including links to
related issues, other PRs, or technical references.

Update the controller to be able to schedule a test to a single worker node via a nodename prefix. This functionality is useful for users who wish to schedule a test to a single node with a supplied prefix instead of all nodes with a given prefix.

Current node selector functionality:

  • node: * - Run on all nodes
  • node: worker* - Run on all nodes with the prefix 'worker'
  • node: $ - Run on a single (random) node
  • node: worker$ - error: no valid agents found to run the synthetic test on, retry after 1 minute ! <--- This PR will fix this

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@kshave kshave changed the title Kshave controller node label updates Update controller logic to include single node selection with prefix Aug 9, 2024
- Update controller to be able to schedule a test to a single worker node via a nodename prefix.
@kshave kshave force-pushed the kshave-controller-node-label-updates branch from 0a297fc to 9127cb0 Compare August 9, 2024 11:15
Copy link
Contributor

@subbaksh subbaksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good :)
Thank you! 🙏

@subbaksh subbaksh merged commit fb58e54 into cisco-open:main Aug 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants