cryptex take 2 #724
Closed
cryptex take 2 #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backport changes from master
Code is merged but tests are disabled and code if #defed out. Starting point for porting after major code changes.
pabuhler
force-pushed
the
cryptex-take-2
branch
from
36734d9 to
4171260
Compare
Move cryptex code to separate functions so it can be reused. Due to support for non in-place io it is not always possible to modify the input buffer in the way the cryptex draft expected therefore use multiple encrypt / decrypt calls when io is not in-place. The gcm ciphers do not currently support multiple operations so non in-place io with csrc's is not supported.
pabuhler
force-pushed
the
cryptex-take-2
branch
from
4e31da2 to
7ed0ea9
Compare
|
changes moved to #511 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative merge of #511 on to main, not complete. Will discuss in the context of #511.