Yatter2 #1
Draft
Yatter2 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bhorinrb As the library management is now made with poetry, I think requirements.txt and setup can be removed. Additionally, coverage library needs to be installed with poetry for its workflow |
dachafra
requested changes
Dec 27, 2024
| .pytest_cache | ||
| tempReadme.md |
There was a problem hiding this comment.
this needs to be removed, just add src/yatter/pycache
| src/yatter/__pycache__/__init__.cpython-311.pyc | ||
| src/yatter/__init__.py | ||
| test/normalize/NORMKEYS-01/mapping_normalized.yml |
|
|
||
| YARRRML_PREDICATEOBJECT = 'predicateobjects' | ||
| YARRRML_PREDICATEOBJECT_SHORTCUT = 'po' | ||
| YARRRML_PREDICATEOBJECT_SHORTCUT = 'po' #eliminar |
| @@ -140,8 +140,14 @@ def generate_extended_join(yarrrml_data): | |||
| for value in equals: | |||
| parameters = [] | |||
| conditions = value.replace("(","",1).rsplit(")",1)[0].split(",") | |||
| parameters.append(['str1',conditions[0]]) | |||
| parameters.append(['str2', conditions[1]]) | |||
| expanded_param = dict() | |||
There was a problem hiding this comment.
maybe this can be done in one or two lines?
| @@ -282,7 +230,8 @@ def get_logical_source(logical_source_id, rdf_mapping): | |||
| raise Exception() | |||
|
|
|||
| if source and reference_formulation and iterator: | |||
| yarrrml_source = [source.value + '~' + reference_formulation.toPython().replace(QL_URI, '').lower(), iterator.value] | |||
| yarrrml_source = [source.value + '~' + reference_formulation.toPython().replace(QL_URI, '').lower(), | |||
| iterator.value] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.