tweak(scripting/lua): speed up lua event serialization. #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are no event handlers for the event, there is no need to unpack or set the source as they will never be used.
github-actions
bot
added
the
invalid
icy4471
changed the title
icy4471
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are no event handlers for the event, there is no need to unpack or set the source as they will never be used.
Goal of this PR
Significantly speeds up event serialization when there are no handlers available.
How is this PR achieving the goal
By returning early when there are no event handlers available.
This PR applies to the following area(s)
FiveM, RedM, Server, ScRT: Lua
Successfully tested on
Game builds: b3095
Platforms: Windows, Linux
Checklist
Fixes issues