Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(state): fix not being able to use any entity native calls in 'entityRemoved' #3043

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

AvarianKnight
Copy link
Contributor

Goal of this PR

Fix oversight in 8957209 which added the IsEntityValid to makeEntityFunction, this is only needed for checks that an entity is valid (i.e. DOES_ENTITY_EXIST, and to a lesser extent, NETWORK_GET_ENTITY_FROM_NETWORK_ID) and pool getters.

How is this PR achieving the goal

Swap back to the old check for makeEntityFunction

This PR applies to the following area(s)

Server

Successfully tested on

Platforms: Windows, Linux

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

Fixes #3042

Copy link
Contributor

@FabianTerhorst FabianTerhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 👍

@FabianTerhorst FabianTerhorst added the ready-to-merge This PR is enqueued for merging label Dec 26, 2024
@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Dec 26, 2024
@prikolium-cfx prikolium-cfx merged commit 6cd7a3b into citizenfx:master Dec 27, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Requires changes before it's considered valid and can be (re)triaged ready-to-merge This PR is enqueued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

entityRemoved event broken since newer artifacts
3 participants