-
-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Api4 SettingsMeta entity and AdminUI Settings Inspector screen #31592
base: master
Are you sure you want to change the base?
Conversation
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
208cae0
to
5d4432f
Compare
@ufundo how is this different from the other Api4 Setting entity? |
@colemanw - this might help answer your question civicrm/civicrm-docker#5 @ufundo - is there a link to a site where I can test this or should i do so locally? |
@colemanw this one is reshaped to be a more standard entity, so it can work with SearchKit @michaelmcandrew see here on the test site: http://core-31592-4jwhi.test-1.civicrm.org:8003/civicrm/admin/settings-inspector |
@totten just tagging you here as I remembered we talked about setting discoverability back in Ashbourne, interested in your thoughts |
5d4432f
to
fbd5903
Compare
Overview
Adds an Api4 entity for inspecting settings meta and values.
Before
After
Technical Details
Want to be careful about exposing sensitive values through the
current_value
key. Added a newis_secret
to DSN and Password settings, but probably should be used in more places.I could be convinced to hold back on the
current_value
column for now.