CIVIMM-249: UI Improvements on compuclient 7.x-4.0 (CiviCRM - 5.75) upgrade #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swastikpareek
force-pushed
the
CIVIMM-249-ui-improvements-after-civi-5.75-upgrade
branch
from
d02cb1d to
59b346e
Compare
swastikpareek
force-pushed
the
CIVIMM-249-ui-improvements-after-civi-5.75-upgrade
branch
from
59b346e to
062b949
Compare
swastikpareek
force-pushed
the
CIVIMM-249-ui-improvements-after-civi-5.75-upgrade
branch
from
062b949 to
547e9e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds basic CSS to improve UI styles of the CiviCRM pages after CiviCRM - 5.75 raised by Jamie on https://compucorp.atlassian.net/wiki/spaces/CN/pages/4682776583/Compuclient+4.0+upgrade+-+UI+Shoreditch+issues document.
Before/After
Technical Details
Most changes were done using plain CSS adjustments. The accordion header styles were taken (and improved) from #565 since that PR was very old, reviewing and expecting the author to update the changes will be time-consuming, so we decided to copy the changes in our PR.
Backstop JS Report
I have tried running the backstop test suite, but some screens of the backstop test suite seem incompatible with the new Civic screens and therefore, I didn't bother to run the whole suite and just ran basic scenario groups - like events, contributions, contacts and administration screens.
All the failed scenarios were related to the spacing and restyling of accordions we did.