Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If keyword is numeric query by order_number #176

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

If keyword is numeric query by order_number #176

wants to merge 1 commit into from
+11 −2

Conversation

ethanstrominger
Copy link
Collaborator

No description provided.

@thadk
Copy link
Collaborator

thadk commented Sep 14, 2022

Hi Ethan, thanks much as always. We discussed this in the meetup but we already solved this using the Carmax-style sidebar UI without the tradeoff of training for the non-numeric phone number search:
image

Can you adjust the PR so that it only has the script change please?

thadk
thadk requested changes Sep 15, 2022
View reviewed changes
Copy link
Collaborator

@thadk thadk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ethan, thanks much as always. We discussed this in the meetup but we already solved this using the Carmax-style sidebar UI without the tradeoff of training for the non-numeric phone number search:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thadk thadk thadk requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanstrominger @thadk