Development Agenda
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan:
- Thad:
- Ethan:
- Terence:
- Aaron:
- Merritt: submitted front and backend PRs re: archiving
- Rachel:
Next week lets' try to make a video of the tests as a showcase on the front page.
- Thad: Talk to CfA, check out new project in 2 weeks. Consider writing a constituent letter via my brother to Rep. Kilmer referencing his points in the modernization cmtte Meeting on July 14, 2022. https://modernizecongress.house.gov/committee-activity/hearings/constituent-services-building-a-more-customer-friendly-congress
- Terence:
- Merritt: Mentioned misc. minor items outstanding on the frontend. Heroku update.
- Aaron:
- Rachel:
- Juan:
- Ethan:
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan:
- Thad:
- Ethan:
- Terence:
- Aaron:
- Merritt: submitted frontend PR #175 debouncing search function
- Rachel:
- Do live coding to support archiving and not actually deleting? Solve: https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/issues/163
- tertiary topic: rxjs to push periodically push updates to other logged in users (not needed for production) https://rxjs.dev/guide/observable
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan:
- Thad:
- Ethan:
- Terence:
- Aaron:
- Merritt: submitted frontend PR #173 welcome page polish
- Rachel:
- When Ethan returns: Do live coding to support archiving and not actually deleting? Solve: https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/issues/163
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: na
- Thad: Away
- Ethan: Pull request for numeric keyword and create run_start.sh
- Terence: na
- Aaron:na
- Merritt: pr 171
- Rachel: na
- Review 2 PRs
- Thad: continue to look for next project.
- Terence: na
- Merritt: use MDN img tips (e.g. breakpoint sizes=) for carousel, resize images, 172
- Aaron: na
- Rachel: na
- Juan: meet merritt for pairing
- Ethan: please think about the archiving not deleting
- Rajinder: thinking of you
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan:
- Thad:
- Ethan:
- Terence: Passed the welcome page content to a writer and waiting for feedback.
- Aaron:
- Merritt: submitted frontend PR #169 Order page css polish
- Rachel:
- Thad:
- Terence: Modifying the Welcome page.
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan:
- Thad:
- Ethan:
- Terence:
- Aaron:
- Merritt: submitted frontend PR #166 Search option for Order Number only
- Rachel:
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: n/a
- Thad: n/a
- Ethan: n/a
- Terence: working on welcome page, pictures and text to be updated
- Aaron: n/a
- Merritt: submitted frontend PR #166: Search option for Order Number only
- Rachel: on vacation
- security, lockouts after bad attempts, captcha
- public demo
- review backlog
Notes from discussion on public demo mode to make it relatively safe:
- Cron option pg:reset
- Password lockdown flag in environment variables
- Thad: cron?
- Terence: working on welcome page, pictures and text to be updated
- Merritt: unified search UI pending adding order_numbers to get_orders query_params
- Aaron:
- Rachel: cypress test
- Juan:
- Ethan: vacation
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: no major updates
- Thad: no major updates
- Ethan: n/p
- Terence: Took photos at the Capitol on Sunday. Working on the copy/text for the welcome page.
- Aaron: n/p
- Merritt: submitted frontend PR #165 continued mobile view refinement
- Rachel: vaycay
- photos of capitol / went down Sunday. Back of capitol where congresspeople enter. Wide-angle shots. Senate and house side. Senate side at 3/4 angle toward front of the building.
- Merritt PR
- Merritt feature request: Search parameter that only searches for the order number?
- Thad: na
- Terence: Text for frontpage and post photos.
- Merritt: Keyword vs. by Order_num search toggle
- Aaron: na
- Rachel: na
- Juan: na
- Ethan: na
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: Nothing to report
- Thad: Met with Ananda last Friday and showed new features
- Ethan: Not present
- Terence: Nothing to report
- Aaron: Not present
- Merritt:
- submitted Frontend PR --> Mobile UI improvements - Issue #162
- condensed Login and LoginSubComponent into one file -> Login
- Rachel: PR for Cyprus tests UI. Also added a couple of issues
- Frontpage (Credit the MSA / Staffer's Association)
- Backend (reset possibly every 24 hours) - automated maybe
- Meeting with Ananda
- Pushed to Heroku reset scheduler
- Thad:
- Terence: Frontpage
- Merritt: Mobility features
- Aaron:
- Rachel: vacation
- Juan:
- Ethan:
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: Not present
- Thad: Set up meeting with Ananda, reviewed pull request
- Ethan: Nothing
- Terence: Vacation
- Aaron: No info
- Merritt:
- worked on Frontend PR error overhaul #151 in conjunction with Ethan's Backend PR Error handling #169
- submitted Frontend PR react router v6 #157
- Rachel:
- Did a small PR for links
- Review Merritt's PRs
- Thad:
- Terence:
- Merritt: Investigate https://reactjs.org/docs/legacy-context.html
- Aaron:
- Rachel: Update Cypress tests. Will write tests for any suggested tests.
- Juan:
- Ethan: No plans
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: nothing this week
- Thad: not here
- Ethan:
- worked on overhauling error handling with Merritt - backend is done probably. draft PR is not yet ready to look at.
- Terence: sick
- Aaron: not here
- Merritt:
- fixed welcome page bug
- changed function to => syntax on error handling
- updated packages to resolve vulnerability errors
- part 1 updating react-router-dom to v6
- worked on overhauling error handling with Ethan
- Rachel: nothing this week, still working on finishing up order page
- error handling
- order page overhaul
- Thad: review react router PR to understand it
- Terence:
- Merritt: continue updating react-router-dom to v6
- Aaron:
- Rachel: will break monster PR into smaller chunks and try to fix last district dropdown bug
- Juan: might shadow/pair with Merritt
- Ethan: work on friendly error messages when order is duplicate (integrityerror)
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad: Was curious what is happening with landing page, but Terence is on vacay. Will do 2-3 mockups. Will be meeting with Congress soon-ish.
- Terence:
- Merritt: Liked formik, think it will make things easier, buttons are good.
- Aaron:
- Rachel: I liked that we got some programming in, will remember to start timer earlier. Also, s/o to Merritt for react router dom PR
- Juan: Finds Merritt's humility amusing :)
- Ethan: Enjoyed discussing error handling
CfA press person wants to showcase our project <3
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: minor changes for the Sort button
- Thad: news article during Code for America, asked us if we want to make a summary for project -> use summary with landing page
- Ethan: worked on error messaging
- Terence: on vacation
- Aaron:
- Merritt:
- Submitted Frontend PR: 141, 143.
- Reviewed Frontend PR: 144
- Rachel: Submitted Frontend Draft PR: 144
- Search by Order Number gives unexpected behavior
- go over committing with Juan's PR
- discuss two ways to error handle
- Thad: ping Loralei on Code Support
- Terence: welcome page content
- Merritt: fix welcome revise PR, change function to =>, upgrade react-router library, npm audit fix
- Aaron:
- Rachel: continuing her PR
- Juan: add more padding, consider column layout
- Ethan: error handling refactor maybe
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad: excited re: welcome page brainstorm
- Terence:
- Merritt: relieved to make progress on erroring, > in progress but good progress
- Aaron:
- Rachel:
- Juan:
- Ethan: liked that Juan did his first PR
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: n/a
- Thad:
- Ethan: worked on understanding messages
- Terence: Working on a landing page for the flag app.
- Aaron:
- Merritt:
- Submitted Frontend PR: 139, 140.
- Reviewed Frontend PR: 138
- Rachel: vacation, plan on finishing revamp
- review PRs
- Address alert (Protect this Branch) on the backend main branch for protection.
- know policy on new contributors (save for Thad)
- Thad:
- Terence: travelling but accessable
- Merritt: silent error messages
- Aaron:
- Rachel: finishing revamp
- Juan:
- Ethan: silent error messages
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: minor update on sort button
- Thad: nothing to report today. did reach out to Ananda last week who suggested we reach back out when status filtering is finished. (should be next week)
- Ethan: Submitted PR to make keyword search case insensitive, should be easy to review. Wrote code ton frontend to wait for user to stop typing for 0.5 seconds. I noticed it has conflicts with Merritt's pull request so I will wait until that is merged and redo.
- Terence: still working on the multiple status queries. single status queries work but multiple don't. should be done in the next few days.
- Aaron:
- Merritt: PR #134 Login Routing
- Rachel: made good progress on FE issue 86
- mob program on multiple statuses? (Team)
- demo improvements to user flow (Rachel)
- demo improvements to sort button (Juan)
- Thad: schedule with Ananda to demo improvements
- Terence: Will look for new issue to work on!
- Merritt: will look into react hooks resets (Thad to share details)
- Aaron: not here
- Rachel: squashing bugs on new edit order page
- Juan: will work on sort interface
- Ethan: Merge changes for waiting until user stops typing after Merritt does his changes. Review error handing in front end - noticed places where errors will silently do a console.log without a pop up box.
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad: stoked+4
- Terence: stoked+3
- Merritt: happy, the polish is getting better, stoked
- Aaron:
- Rachel: also stoked, thrilled that we solved the multi-status search
- Juan: good, maybe next time will make a draft PR
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: working on Merritt flexbox idea to keep the toggle button of "sort by" on top.
- Thad: Just got the email from Ananda confirming receipt of the gist login link sheet.
- Ethan: Keyword search implementation
- Terence: Worked on multi-statuses query with Ethan, still needs some tweaking. Want to deliver PR before Friday.
- Aaron: Gauge hover update
- Merritt: worked on PR #126
- Rachel: coming
- Review PRs
- Aaron's gauge hover arrangement on mobile.
- Demo the keyword search implementation (ethan)
- make a splash landing page, put recording of cypress tests with button to run on splash page, write up, or other showcase of our work
- cypress test - team code (catch up from Merritt's PR)
- Review tests
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: sort button UI adjustments
- Thad: n/a
- Ethan: started work on keyword query
- Terence: n/a
- Aaron: n/a
- Merritt: submitted PR # 127 suggested code for consideration for branch RK/sync-query-string-and-form
- Rachel: vacation
-
Round Robin suggestions
-
look at Juan's button work
-
review zenhub
-
review PRs
-
cypress test - team code
-
debug keyword query
- Thad: think about -> make a splash landing page, put recording of cypress tests with button to run on splash page, write up
- Terence: quesy - multiple statuses query w/ Ethan
- Merritt: fix react-select label accessibility
- Aaron: issue 76 - gauge display
- Rachel: back from vacation
- Juan: work on sort button
- Ethan: work on keyword query
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad: look out for other projects
- Terence: peer coding flew by
- Merritt: good to have Aaron back
- Aaron: good to be back
- Rachel: was missed
- Juan:
- Ethan: mob programing was great and great to have Aaron back
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: working on PR #117 to add sort button and UI
- Thad: no updates
- Ethan: nothing until next week (pairing w. Terence). Merritt approved the code.
- Terence: nothing until next week
- Aaron:
- Merritt:
- Rachel: PR #123 keyword in search bar, potential issues with dropdown (keyword works well).
- Round Robin suggestions
- Coding (Click here for some coding options.)
- Tests to finish from last week (frontend)
- Think about how to send the demo links
- Rachel PR
- Thad: Maybe send demo login link? Figure out which bookmarks are needed. Email them a link on their behalf.
- Terence: Meeting with Ethan
- Merritt: Want to do small UI and edit button going away when not admin. Edit UI is chunky. Simply figure out what's going on with React-Select.
- Aaron:
- Rachel: Out next week
- Juan: #117
- Ethan: Meeting with Terence
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: Worked with Merritt.
- Thad: Updated Heroku. Refreshed the tables.
- Ethan: Fixed state route. Each state lists all offices. Worked w/Terence on adding state queries. Fixed issues on backend tests and removed "Delete all status codes".
- Terence: Worked on adding state query.
- Aaron:
- Merritt:
- Rachel: Submitted PR #119 for querying the backend. Opened new issues 115 and 117.
- Round Robin suggestions
-Removed "Delete All" button from the bottom of the UI.
- Are these issues done? (Yes!)
- Cypress
- Fix Cypress issue (for learning purposes)
- Understand how react-select-7-input works (only found in one place)
- Are these issues done? (Yes!)
- Thad: Probably something cool (we don't know, he left)
- Terence: Work w/Ethan on backend work on search by multiple statuses
- Merritt: Add confirmation/fail safe button for page refresh.
‼️ also might work on auto-login route - Aaron: not here
- Rachel: Work on FE issue #120
- Juan: Sort by: Improve appearance in the html. Modify buttons?
- Ethan: Work with Terence on search by multiple statuses, change reset to send response only after success, review commented out test case
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Terence: +2 on mob coding / cypress
- Merritt:
- Aaron:
- Rachel: agreed on mob coding
- Juan:
- Ethan: mob coding on cypress, let's do more of that, really enjoyed cypress work
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: worked on Frontend PR #114 w/ Merritt
- Thad: nothing specific, have not heard from Cong. team
- Ethan: 3 PRs (reset route, add query param processing (will query by office code), ) and updated stable orders to incrementally update records to engage the log table, issue updates
- Terence: Created two pull requests (Fixed order_log_model update when scan is used on Frontend). Currently working on issue #143
- Aaron:
- Merritt: worked on Frontend PR #114 w/ Juan, initial review of Frontend PR #113 (issue #83)
- Rachel: Frontend PR #113
- Round Robin suggestions
- get_states in office_actions throws an attribute error when called.
- Multi-select for status?
- Naming of query parameters (Both Front and Back end)
- keyword
- state
- office_code
- status_codes (previously status)
- Forget about active (since can do multi-select)?
- pointers to implement search button (Frontend)
- questions for Rachel regarding UI tests
- review PRs
-
log in link, good progress point
-
parse status codes using contains on backend
-
push to heroku then update Cong staff
- un tilt the design
- search/filter drop downs added to screen but not yet functional
- reset link (needs to be pushed to heroku)
- refactoring on the front end to make statuses show up clearer (gauges adjusted: status names instead of numbers)
- log in menu design cleaned up, current user listed in top right corner (used to be inconsistent)
-
Thad: send email and update heroku, play with add order bug on backend, trial w/ postgress
-
Terence: pair with Ethan re: params search feature
-
Merritt: yup npm and put warnings on bottom of Edit and remove QR code from Edit and stack forms with bootstrap
-
Aaron:
-
Rachel: make the status select into multi select and trigger new getOrder route
-
Juan: pair on Slack
-
Ethan: pair with Terrance and finish status conflict resolution
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
================================================================
(Thad's birthday!)
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: nothing this week
- Thad: busy meeting w/Ananda etc
- Ethan: nothing this week
- Terence: Nothing New: Closing Activities at Work had been priority
- Aaron:
- Merritt:
- Rachel: Nothing!
- Round Robin suggestions
- Coding (Click here for some coding options.)
- Discussion of FE testing strategy
- Discussion of demo links
- status of Issue 83 and possible coding
(See relevant issues)
-
UI that alters the query params, (https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/issues/83)
-
fetch to backend from the query params (https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/issues/83)
-
backend that responds to the request that includes the 4 or 5 specific search terms. (https://github.com/codefordc/us-congress-pizza-flag-tracker/issues/143)
-
demo auto-login links (UI)
-
Thad:
-
Terence: and Terence (controller) #143
-
Merritt: work with Juan cleaning up error handling
-
Aaron: https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/issues/109
-
Rachel: #83 first part, mb second
-
Juan: message team on slack to shadow.
-
Ethan: Ethan (parameters + router) #143 #109
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: out
- Thad: No updates
- Ethan: Birthday, made https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/issues/109
- Terence: Team identified scan issue, Terence is going to look at it.
- Aaron: We looked at PR and made https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/issues/110 as new bug appeared on scan page.
- Merritt: out
- Rachel: out
- Round Robin suggestions
- Coding (Click here for some coding options.)
Gauges Ideas:
- remove the "1.", "2.", etc. from gauges
- padding so even when centered earlier gauge text is tight, it look okay.
- Font size of earlier gauges
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: No updates this week, but has joined
- Thad: informal 30m meeting with ken & Ananda, see notes in next section
- Ethan: out, moving to new house this week
- Terence: last week's work still in progress
- Aaron: out this week
- Merritt: polished PR 106 frontend
- Rachel: thinking about mocks & fixtures (& going forward)
Ken would welcome anything to facilitate demos
- direct sign in links could be helpful.
- UI change.
- important to not break heroku & its data
- development vs. production servers?
Shoot a note to them with things in progress.
- Please document changes going forward in a changelog.
- Demos could be in 2 weeks or 2 months: not clear yet
- how to capitalize on all the team's time and work, show it in the best light.
- Conversations internally on House Digital Service hiring, onboarding some people to work on these kinds of things. This is one of the things for House Digital Service to run with.
- Round Robin suggestions
- Coding (Click here for some coding options.)
- Thad: new changelog file
- Terence: working on refactor routes for officeState and Status, figuring out why updating Status from frontend won't update orderlogmodel
- Merritt: clean up the PR, run analysis using Lighthouse, review the Issue file
- Aaron:
- Rachel: research into cypress testing integration into full stack app
- Juan: reach out to team on slack to pair with, schedule permitting
- Ethan:
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Terence: cool to watch
- Merritt: was good to do ensemble programming again
- Aaron:
- Rachel: zoom remote control better than anydesk (ensemble programming)
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: new job!
- Thad:
- meeting with Ken
- environment set up
- Ethan:
- meeting with Ken
- Terence:
- meeting with Ken
- working/debugging on the scan issue -> not updating log
- simplifying queries for state, office, status
- Aaron:
- meeting with Ken
- got last PR in, style review
- fix logging in an out - in progress
- Merritt:
- meeting with Ken
- PR 106 time limit on orders incrementing to complete
- Rachel:
- 2 PRs, fix cypress tests w/ data attribs and fixed show order log table
-
Round Robin suggestions
-
Coding (Click here for some coding options.)
-
a PR or two
-
review Ken's feedback
- Thad: emailing Ananda/Ken with questions re:feedback
- Terence:
- working/debugging on the scan issue -> not updating log
- simplifying queries for state, office, status
- Merritt:
- review https://github.com/you-dont-need/You-Dont-Need-Momentjs#difference
- Lighthouse web app analysis/rate testing
- Aaron:
- gauge issue scan privileges work regardless of user
- ideas for presentation
- Rachel:
- on vacation, be back in May
- Juan:
- connect on Slack for collaboration
- Ethan:
- PAX conference
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad: the potential that they'll run with our project
- Terence: +1 w/ Aaron
- Merritt: love to get feedback from Ken
- Aaron: feel great about the progress
- Rachel:
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: Not here
- Thad: Confirmed meeting for next Tuesday 4/26 from 12:30 pm to 1:30 pm
- Ethan: Worked on active and not active queries.
- Terence:
- Created queries for usa_state, status, and office and pull request
- working on active orders (Ethan is working on this)
- Aaron: Submitted a pull request for changes discussed last week.
- Merritt:
- approved PR 101 add loading status
- worked on Reversion Timeout limit for orders being incremented to Complete on Scan Page.
- Rachel: Added loaded status indicators, list of orders, and order log.
- Round Robin suggestions
- Coding (Click here for some coding options.)
- Review Zenhub to make sure TODO tasks are complete. (1)
- Check for order_log data in the Heroku branch (2)
- Upcoming presentation (3)
- Thad: Tuesday's presentation
- Terence: Tuesday's presentation, code review with Ethan on queries, and update status scan issue with order_log.
- Merritt: Tuesday's presentation, also wrap-up the completion, reversion timeout.
- Aaron: Tuesday's presentation, add the names of the constituents to orders, log in from scan page bug. (issue #87 on frontend)
- Rachel: Rerun Cyris test, fix order_log bug, and toggle
- Juan: Not here
- Ethan: Tuesday's presentation code review and active status query
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Terence:
- Merritt:
- Aaron: Excited about the presentation on Tuesday +1 -Rachel
- Rachel:
- Juan:
- Ethan: Good meeting, the agenda worked well
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: not here
- Thad: nothing major to report, we have to decide on the date of presentation to Ken. Ethan can't make suggested time.
- Ethan (see note in Slack for details):
- modified backend response for orders to include mock constituent info
- fixed bug in the backend when scanning (found when running Cypress tests)
- modified Cypress check for change to the wording on the button (found when running Cypress tests)
- added Ananda's issues and UI suggestions to GitHub
- prioritized on Zenhub
- reviewed PRs
- Terence:
- refactored order_log_model and submitted a pull request
- The refactor implements a new table order_count that records the number of times an order has been updated.
- The refactor also includes a function call to return sorted order_logs by order_number to the frontend
- refactored order_log_model and submitted a pull request
- Aaron: got started on some of the UI suggestions from Ethan, looking for feedback from the group today
- Merritt:
- Rachel: PR #82 Frontend logging
-
Round Robin suggestions
-
Coding (Click here for some coding options.)
- Thad:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: nothing to report this week
- Thad: corresponded with ananda
- Ethan: working on implementing new security fields for the user, not ready yet
- Terence: merged log into main (Ethan); only thing not done is populate log when populate script runs. it will have forthcoming changes: how to sort orders when they are pulled to the frontend? when you get previous order UUID, while it works in dev, might not work in postgres. so will need to implement sort order to get most recent UUID. another table forthcoming.
Also attended hackathon (with Merritt?). it's not a real hackathon, it's more of an ideathon. but a lot of ideas at previous hackathons have in fact been adopted. 15 groups presented during lightning round. Ananda presented flag app. Ken went up and mentioned us <3 then breakout groups --Terence went to the constituent casework group. that group settled on looking at who owns the data for the casework once that congressperson leaves office. currently, all open cases are closed as the outgoing congressperson leaves, but the default is no. also suggested developing a "handshake" between the 7 different CMSes that congressional offices are allowed to use. other groups, not attended by Terence, included cybersecurity and communications. Met Ananda & re-met Ken.
- Aaron: Not much last week.
- Merritt: Not here
- Rachel: Updated Cypress tests, recorded new video & shared w/Terence
- Round Robin suggestions
- Features discussed with Ananda (mtg w Terence, Thad, Ethan)
- correct the colors (MAIL and cong. staff are currently represented by the same color, but should be separate. 5 should be separate from 6, but 6 should be same as 7) COMPLETED
- *add user that updated to the order log (this is on the agenda already)
- *add constituent name, email, and phone on the Order list page
- *add constituent name, email, and address on detail page
- *query by status, and office (needs UI discussion but probably omni-search but with option to do advanced search w/ multiple fields)
- query/filter by active or not. For FED-AOC, FED-MAIL, FED-HOSS, order is inactive once the next office receives it. For FED-ADMIN and state offices, orders with status of closed or deleted are inactive.
- Features discussed with Ananda (mtg w Terence, Thad, Ethan)
(* denotes backend work/changes to the db model)
- Coding (Click here for some coding options.)
- Thad: not here,
- Terence: new things for order log model, will also look at implementations for backend. will work w/ethan on new columns
- Merritt: not here.
- Aaron: working on detail errors and will make PR for updated colors.
- Rachel: work on frontend for order log model
- Juan: transitioning to a diff job and going on vacation. see you in 2 weeks!
- Ethan: will work w/Terence on new db columns. and maybe work on queries for filtering
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time? Rachel: liked that we got coding in. Ethan +1 Terence: The hackathon was awesome. glad that we are able to send the order logs to the frontend.
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: Python variable question.
- Thad: No major updates, email from Ananda in slack.
- Ethan:
- Updated documentation for making schema changes
- Renamed ...mysql to ...sqlite (and updated documentation)
- Entered enhancements (issues)
- Updated zenhub project plan
- Terence: Updated the order_log_model and fixed all known errors. The order lof model is ready for the main branch.
- Aaron:
- Merritt: Polishing requests & suggestions submitted in the meeting last week on frontend in status advance PR.
- Rachel: Made dummy data on order log (using column names) and made a demo of how it would look.
- Round Robin suggestions
- Review Ananda's requests
- Security
- order log UI wireframe demo
- in schema and backend, let's collect user who made a change when order logging
- in API, statuses spelled out using an object on the backend, not just a number
- on UI, indicate
(current)
- Python variable question.
- Merritt's PR.
- Review enhancement suggestions (white for menu, user on the right, query by status/state/office code, active orders)
- Review Zenhub
- Coding
- Thad:
- Rajinder:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan: Change over to new schema for users in UI and backend
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Rajinder:
- Terence: Shared with friends and they're excited about this project. Great code reviews.
- Merritt: Pretty excited about real close to things coming together.
- Aaron:
- Rachel: Ananda email. Order log compoennt
- Juan: Apr 18 starting new schedule at work. Was building in assembly, do a bit of javascript, learning python.
- Ethan: Ditto what Rachel said, reviews on security doc, great demos.
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan:
- Rajinder:
- Thad: Followed up with Ananda
- Ethan: DB setup script adjustment: no major change in usage, fixes some error messages.
- Terence: Testing the order log model, Ethan and T got it merged earlier. Positional argument errors/type errors on
order_status_id. - Aaron:
- Merritt: resolved conflicts between my PR another merged PRs, reviewed PR# 71 move frontend error handling to separate function, worked on handling timeout for undo - should have a PR for next week
- Rachel: out this week, working on first frontend for order log model while gone
- PRs
- New Script Options: 1) "regenerate schema and recreate data" or 2) "incremental schema change + data script to populate new columns" (with
flask db migrate/alembic). Ethan recommends we continue to use #1 as we don't have actual data or need for data scripts. - Positional argument errors/type errors on
order_status_idfrom Order log model. - Add test that logs into mailroom at status 5,
- perhaps adjust grounding colors accordingly.
- Round Robin suggestions
- Coding (Click here for some coding options.)
- Thad:
- Rajinder:
- Terence:
- Merritt: PR for blocking Reversion if order was incremented to Complete AND increment is over an hour old
- Aaron:
- Rachel:
- Juan:
- Ethan:
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Rajinder:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: question about reverting changes on a parallel branch that was already merged.
- Rajinder:
- Thad: the initial demo video for Ananda.
- Ethan: I just spent a couple hours updating the security document - I am hoping this is the final version, made it even more clear, especially for UI implications. Over half of the time was trying to get the table that displayed users and their privileges to look good. Then, I split into two tables, one for order security and one for user security and it looked good and easier to review. Can someone review?
- Terence: Ethan and Terence worked on order log model to be integrated. Import error: TBD hunt.
db initchecks the imports on db and models. It says it is coming from app.py but that was not modified. - Aaron: Finally got last PR with scan redirect working, adding the admin portion of the password, right beneath Rachel's regular user code. Thinking about styling: orders loading spinner; titles on hover.
- Merritt: presented in demo video, looked into cypress account log in errors, fixed skip status PR, clear search PR, updated Heroku
- Rachel: cypress upcoming
- Round Robin suggestions
- Coding (Click here for some coding options.)
- Record cypress test video for end of other one?
- hunt for import on data model from Terence.
- Thad: Prepare videos.
- Rajinder:
- Terence: Finish testing the order log model. Things to take care of from backlog of issues.
- Merritt: Re-review security doc from Ethan on Scan Page. Ethan had a request when an order gets advanced to give them no more than an hour (frontend). Connect with Rachel on Cypress help.
- Aaron: Fix styling errors, make sure login and scan page fills the screen on mobile. Larger target area on edit/scan/print buttons.
- Rachel: [Not here next week, but would like to do 2 wks of things] UI for Order log building off Terence's work.
- Juan: Revert the change from #121 for methods with 3+ variables. <>
- Ethan: new columns for user table, keeping the same columns until they are no longer used.
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Rajinder:
- Terence: Cypress is awesome
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: Last time, named keyword arguments: Ethan said only do it for 3+ variables methods. Very few with 3 or more.
- Rajinder:
- Thad: Trial run demo scheduled for Friday with Ananda at 10am.
- Ethan: Revised security document (last time we went through it and realized a few tweaks). Can be a natural part of the demo to just mention some of the items from it.
- Terence: 2 pull requests on the backend for the order log model. Added admin feature to
get_all_users()API for listing out all the users of the app: Aaron was thinking to work on that admin list page on the frontend. Last week, anybody wanted to see all the users they could. - Aaron: Update password page, skeleton of it without wiring to the backend. NEED: boolean on backend for
to_be_flownstatus of flags. - Merritt: Reviewed security doc in prep to re-review my PR. Reviewed Date-FNS as a component that might be useful to close out the complete status.
- Rachel: One PR fix.
- Jenny: UX, 2 certificates.
- Ric: Software dev, 20 years.
- Round Robin suggestions
- Coding (Click here for some coding options.)
- Talk about
to_be_flownvia security doc. See who will implement particular pieces. - Who's gonna do what this week? (Go through backlog + security doc: different people volunteer)
- Last time: wanted to run backend in debug mode.
Date-FNS- UX ideas to prep for Friday?
- Thad:
- Rajinder:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Rajinder:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: Sent pull request for named parameters
- Rajinder: Terence and I worked on the admin password tests
- Thad: Sent Ananda an email requesting a meeting on Friday and questions
- Ethan: Revamped the security document based on the discussions from the last meeting.
- Terence: I worked with Rajinder in the Admin tests and created the route and function to display all users.
- Aaron:
- Merritt:
- Rachel: Wrote Cyprus tests to move flags from one office to the next and encountered errors with the code.
- Round Robin suggestions
- Coding (Click here for some coding options.)
- Running the backend in Dev mode (running the front-end tests with the backend in dev mode)- Tabled to next week
- Review the Security Doc 1
- Walkthrough the security code 2
- Admin tests (password change) 3
- Thad:
- Rajinder: Work with Terence to work on Admin password tests
- Terence: See above and add new security fields
- Merritt:
- Aaron:
- Rachel: Will try to address changes on the pull request and make the front-end user list.
- Juan: Fix Pull request for the keyword arguments.
- Ethan: Clean up the security document. Maybe change the variable names in a function.
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Rajinder:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- Ethan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: said he couldn't make tonight
- Rajinder: ?
- Thad: nothing new
- Ethan: submitted a PR, working on improving the build scripts (copies .env automatically), reviewed PRs, started convo re: get Cong to adopt this without waiting for full implementation
- Terence: will submit PR for order log model tomorrow, code reviewed with Ethan, testing before pushing PR
- Aaron: PR waiting for scan page (check to see if it properly reroutes people), handled permissions for add order button
- Merritt: cleaned my backend PR from last week, submitted new PR to handle to let staffers skip mail office
- Rachel: PR to componentize error handling, all errors call single function, work in progress
- Round Robin suggestions
- Coding (Click here for some coding options.)
- discuss getting Congress to adopt this without waiting for full implementation
- review backlog
- Thad: send questions to Ananda via email, then follow up with Ken aiming for March 4
- Rajinder: work on wrapping up password issues with Terence
- Terence: work on wrapping up password issues with Raj, user query implementation
- Merritt: update the skip PR, and iron out some edge cases
- Aaron: work on Backlog, check with Terence/Raj, tweak margin
- Rachel: tweak PR, check with Ethan re: error handling, multi-user cypress tests, test server for cypress tests w/ Ethan
- Juan: ?
- Ethan: format Questions for Ananda for clarity, test server for cypress tests w/ Rachel, write Ananda, write up Security rules, refactor names for error handling
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad: good, just tired; liked talking about adoption
- Rajinder: n/a
- Terence: tired, but happy with progress; excited to work on user queries
- Merritt: slightly tired, but in good spirits; happy anticipating the feedback from Ananda and Ken
- Aaron: good, keep progress going; keep rolling!
- Rachel: liked the convo re: adoption, feeling good
- Juan: n/a
- Ethan: feeling very good, not tired; pleased with ideas for adoption and enjoyed convo re: error handling
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: Has a pull request for python scripts. Refactored variables to keyword arguments.
- Rajinder:
- Thad:
- Ethan: Did a code review for the log_order_model with Terence
- Terence: Reviewed the log_order_model with Ethan
- Aaron: Reviewing feedback for the pull request on the frontend
- Merritt: 2 PRs: remove the remove all and populate all the user accounts for states.
- Rachel: Working on Cypris tests
- Round Robin suggestions
- Coding (Click here for some coding options.)
- Error handling on the backend (15-20 minutes)
- UI PR from Aaron (5-10 minutes)
- Approved PR. Suggested having an option to modify slant so orders show up level
- 2 PRs from Merritt (10 minutes)
- Approved one. Will work with Ethan on the second.
- Review the backlog (10 minutes)
- Thad:
- Rajinder:
- Terence: Complete phase 1 of the log_order_model and push a PR.
- Merritt: Look for an item on the backlog to complete.
- Aaron: Work on the redirect scan from the backlog.
- Rachel: Clean up the error handling code for the frontend
- Juan: Work with Rachel on Cypris
- Ethan: Refactor the error handling on the backend. Write the security rules for users. Look at status rules with Merritt.
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Rajinder:
- Terence: Pleased with progress. Learn more about JWT.
- Merritt: Great having Ethan back. Happy with progress.
- Aaron: Pleased with progress and where we ended today.
- Rachel: +1 with Aaron
- Juan: Optimistic
- Ethan: Happy with how unexcited the meeting was: Things are running smoothly. Everyone knows their task well. Happy not to be the recorder.
- This format works well.
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: Backend environment issues. Migrations missing. (Related to prev. PR?)
- Rajinder: TK?
- Thad: Demoed project w/Merritt. Learned Cypress!
- Ethan: Still on vacation??
- Terence: Making good progress on the log_model. I added functionality to the log_controller and log_action files.
- Aaron: Busy w/interview prep, waiting to hear back on demo design feedback.
- Merritt: Reinstated scan button, attended demo meeting, reviewed PRs
- Rachel: Wrote initial frontend page to handle SELF password changing, tested with FED-ADMIN user.
-
Round Robin suggestions
-
Layout/design feedback/review
- Standard Sort Order in the app (either: created date descending, or status as default would be okay)
- Create flag and take it from Step 0 to step 8 in a cypress test.
- Grouping pizza tracker diagram by office using gaps to distinguish.
-
-
Review PRs
-
Terence present progress on log_model
-
Check app against MVP list
-
Coding (Click here for some coding options.)
- Thad:
- Rajinder:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Rajinder:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
(Crash, but it happened :)
- Round Robin suggestions
- Coding (Click here for some coding options.)
Demo Plan:
- Open site on computer with screen share
- "Scan" QR Code
- Advance the status
- sort by order status descending.
- Search for a flag
- Press edit button and show how you can change a flag.
- Run Cypress testing
- Thad:
- Rajinder:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad: Hoping to feel well for the demo. Glad to see password code.
- Rajinder:
- Merritt:
- Aaron: Feeling pretty good – progress
- Rachel: Feeling good
- Juan:
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: bug hunting, met with Rachel re:cyp
- Rajinder: Terence and I were able to complete the password issues (i.e. the user should be able to update their password and an admin should be able to update a user password). We still need to complete the tests, however, the frontend team can start coding for these added features.
- Thad: scheduled the demo
- Ethan: vaykay
- Terence: Rajinder and I were able to complete the password issues (i.e. the user should be able to update their password and an admin should be able to update a user password). We still need to complete the tests, however, the frontend team can start coding for these added features. I also added a potential topic for the agenda below.
- Aaron: pizza tracking gauge
- Merritt: troubleshooting backend setup
- Rachel: Cypress, met with Juan re:cyp
-
Round Robin suggestions
-
fix issues people were having with the backend - done
-
Cypress
-
Terence and Rajinder: Two pytests are failing: tests/actions/test_order_actions.py::TestOrderActions::test_get_orders & tests/routes/test_auth.py::TestAuth::test_if_not_is_admin_cannot_add_user
-
Coding (Click here for some coding options.)
- Thad:
- Rajinder:
- Terence: - Building the password tests with Rajinder and order logging.
- Merritt:
- Aaron:
- Rachel:
- Juan:
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Rajinder:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: PR to see about keyword args
- Rajinder: Rajinder and I updated the update_user and created the update_password functions. We also created tests for update_user.
- Thad: Thad and Merritt updated Heroku
- Ethan: Nepal? until Feb 9
- Terence: Rajinder and I updated the update_user and created the update_password functions. We also created tests for update_user.
- Aaron: PR separating routes out, perm folder, changes to file struct
- Merritt: set up Status update for the Edit
- Rachel: Documentation for Cypress, including readme and sample files, logging in less brittle
- Round Robin suggestions
- Juan PR: Refactored func add_offices to keyword arguments - merged
- Aaron PR: UI security updates -> changed file structure, merging?
- Rachel PR: Create readme, sample files for tests -merged
- Merritt PR: wired up status changes for Edit View - merged
- Terrance and Raj PR: updated the update_user and created the update_password functions
- Coding (Click here for some coding options.)
- Thad: schedule Congressional group demo 2 Fridays from now
- Rajinder: Complete password permissions with Rajinder and continue to work on logging model.
- Terence: Complete password permissions with Rajinder and continue to work on logging model.
- Merritt: Look at MVP / print QR page
- Aaron: pizza meter!
- Rachel: connect with Raj about password stuff, connect with Juan re:cypress
- Juan: refactor more functions and test them, connect w/ Rachel re:cypress
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad: liked how everyone started without me
- Rajinder: sorry missed first half
- Terence: swim meet
- Merritt: loved how the merged went really smoothly; great work everyone
- Aaron: great momentum, ready to keep working
- Rachel: agree, so much done
- Juan: grateful for all the group's time
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: Backend, on Python refactor, all functions to keyword, named arguments. Request to unstick.
- Rajinder: PR #114 just before meeting. If you're logging in from
AZ-01, you'll only see that district's flags. Rachel up to test different accounts with Cypress, perhaps. Assumes these username formats:State-NumberorFed-Somethingotherwise returns nothing. Add something for State-Number-Admin (AZ-01-Admin/ that is the user that changes password)? - Thad: Demo'd to congressional team, Terence and Ethan were there. Hope to schedule a meeting with Ken at House Tech sometime in next few weeks once MVP is stable and we're happy with it.
- Ethan: vaykay
- Terence: not yet / restructured the folders in the app - authorization controller, etc. are no longer in the base folder.
- Aaron: Environment setup script goes though, but then permission issue
- Merritt: Figured out why weird error with admin when advancing the status (if something doesn't exist no permission). Variable changed in the refactor, so you couldn't pull the next status. https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pull/57 We still need to update heroku with #113.
- Rachel: Cypress and then Vaykay. Looking into React Storybook.
-
Round Robin suggestions
- Review Rajinder PR to think through what flag might disappear
- Aaron's environment check
- Check Juan's stick point
- Try to update Heroku so that it has Merritt's fix for status (offline)
-
Coding (Click here for some coding options.)
- Thad: Pair with Merritt on Heroku
- Rajinder: Admin level password change/reset.
- Terence: Log/Transaction table, user being able to change password on the backend (user level password change).
- Merritt: Pair with thad to update heroku with 2 new PRs. Add page -> Wire up statuses.
- Aaron: PR coming for UI security changes in the next few days, then styling changes.
- Rachel: Cypress docs TESTING.md? check on localStorage extension? React Storybook per Ethan.
- Juan: Will talk to Ethan and see what to achieve with Kwargs and maybe join someone else on another thing.
- Will?
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad: Learned: There is no double splat in javascript.
- Rajinder:
- Terence:
- Merritt: Insights!
- Aaron:
- Rachel: Python! Splat operators (*, **)!
- Juan:
- Will: Splats (**), Spread operators (...)
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan: Studied
- Rajinder: Not present
- Thad: Fixed formatting error for Safari, self-demoed MVP
- Ethan: Simplified scripts
- Terence: Working on log table, found workaround
- Aaron: Changed UI, determined styling
- Merritt: Review simplified scripts
- Rachel: Not present
- Round Robin suggestions
- Date formatting in Safari (15 minutes)
- Look at production MVP proposal (15 minutes)
- Is it correct?
- Look at issue for refactoring, got stucks / bcrypt encryption (15 minutes)
- (Thad looking it up) (15 minutes)
- Look at two proposals for log table (15 minutes)
- Coding (Click here for some coding options.)
See backlog
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Ethan: Neutral. Learned about Safari and different log options.
- Thad: Learning about different logging options. Agenda flow worked well. Super happy to do whole flow on Heroku during break.
- Rajinder: Okay.
- Terence: Satisfied. It has come a long way, encouraging to see process and where we are getting it to.
- Merritt: Eager. Enjoyed break. Interested to see how logging turns out.
- Aaron: Great. Eager to see MVP get done.
- Rachel: Not present
- Juan: Optimistic, excited.
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Cancel should not say Order updated
- Cancel should hide button and Next Status
- After successful update, show revert button. Press Revert, go back and show Update
- Change QR code to point to scan
- Juan: Request failed with status code 500, Linux challenges
- Thad: No progress
- Rajinder: Can't get it to work
- Ethan: Got gitpod to work
- Terence:
- Aaron: Updated some UI updates, order list, pointed to Heroku
- Merritt: Submitted PR for scan order, hoping final
- Rachel: Getting started with Cypress. Need to figure out how to log in once.
Click here for some coding options.
-
Round Robin suggestions
- Demo from Aaron on UI
- Demo from Merrit on scan and discuss proposed changes
- Demo on gitpod from Ethan
- Config frontend to use Heroku for Juan
- Troubleshoot Rajinder's env
-
Coding
- Ethan:
- simplify scripts
- move scripts into subdirectory
- populate orders into heroku and document process
- write up security/UI rules for updating status and adding office code
- Thad:
- Send link to DC team
- Rajinder:
- Update status (maybe update bug only)
- Merritt:
- Change URL to point to scan UI (look for qrcode.make(frontend_url + "/api/orders/" + uuid), change to scan
- Implement above findings from PR
- Aaron:
- Submit PR with current UI changes
- Work more on UI
- Rachel:
- Work on Cypress, try to find time to work with Aaron
- Juan:
- Ad hoc, maybe debug, work with Rajinder
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad: Liked raise hands, improve: some times make suggestions immediately
- Rajinder: Happy env got working, glad get back to work
- Merritt: Love the UI, improve: raise hands
- Aaron: Good mood, happy with how making progress
- Rachel: Time boxing worked well, raising hands good
- Juan: Relieved that working and grateful to everyone
- Ethan: Really timeboxing, appreciated Rachel keeping on time / try raise hand
=================================================================
- Ethan & Terence would like to meet to troubleshoot.
- Rachel and Cypress tests (optional tutorial monday 6:15pm with Ethan)
- Merritt: polish QR view (clean up buttons, handle save confirmation / prevent accidental double click, handle setting Cancel status, separate non-std lifecycle statuses out before calculating nextStatus)
- Aaron try to use frontend:
REACT_APP_BACKEND_API=https://codefordc-flag.herokuapp.com(otherwise Ethan will meet to help with mocking) - Review Rachel's tiny PRs.
- Ethan will continue to play with Gitpod (remember to make sure .env is even working for frontend)
- Terence: logs, logs and more logs. Esp if app environment can come online.
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad: Got demo'd.
- Terence: They're excited about where it is and we're we're trying to take it to.
- Merritt: Git resolutions and so forth, appreciation
- Aaron: Frustrated with app, eager to get to work.
- Rachel: Second aaron's frustration: 2wks in a row v simple thing, not aaron's fault.
- Ethan - great see what issues are and make progress, heroku working
=================================================================
- https://github.com/codefordc/us-congress-pizza-flag-tracker/pulls
- https://github.com/codefordc/us-congress-pizza-flag-tracker-frontend/pulls
- Juan:
- Rajinder:
- Thad:
- Ethan:
- Added logic to refresh token (paired with Rachel)
- Reviewed several pull requets
- Terence:
- Aaron:
- Merritt:
- set up basic framework for view when user "scans" a QR code and wants to increment status once
- added ACTIVE_STATUS (OPEN, CLOSED, CANCELLED) and STATUS_CODE (description abbrs) to Backend
- fixed EditOrder and ScanOrder changes being sent to backend but not updating backend
- Rachel: Added front-end logic to refresh token (paired with Ethan) -Wrote basic sorting logic (last week)
- Round Robin suggestions
- is providing statuses definition table with response.order.data worthwhile? in my current PR, statuses are called separately once when user gets to the ScanOrder view, but doesn't get called on subsequent rerenders; only gets called if the page is reloaded.
- Coding
- Click here for some coding options or open new tab for issues
- Ethan: dotenv issue, make script work for windows
- Thad: Fix Heroku
- Rajinder:
- Terence: log table and resolve script issue
- Merritt:
- polish QR view (clean up buttons, handle save confirmation / prevent accidental double click, handle setting Cancel status, separate non-std lifecycle statuses out before calculating nextStatus)
- Aaron: Work on frontend stylilng
- Rachel:
- Juan:
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time?
- Thad:
- Rajinder:
- Terence:
- Merritt:
- Aaron:
- Rachel:
- Juan:
=================================================================
==================================================
(Determine order using Mob Timer)
Juan:
- Accomplished: Worked with Rajinder on the back end dictionary.
- Agenda topic (questions, roadblocks, help requests, topics, demo): None.
Rajinder
- Accomplished: PR for the status that Ethan was going to review.
- Agenda topic (questions, roadblocks, help requests, topics, demo): None.
Thad
- Accomplished: Got Heroku working again.
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- Quickly talk about that Heroku blocker.
- Talk about the front end style approach.
Ethan
- Accomplished: Refactoring, fixed tests to adjust for change in order status being added and change to how items are turned to json. Added environmental variables. Updated Heroku.
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- Code!
- Demo Merrit's scan
- Q on lint
Terence
- Accomplished: Researched flask logging for transactions/triggers.
- Agenda topic (questions, roadblocks, help requests, topics, demo): None.
Aaron
- Accomplished: UI and style changes.
- Agenda topic (questions, roadblocks, help requests, topics, demo): Run through merge pull request about the status dictionary. See what the response is.
Merritt
- Accomplished:
- set up basic scan page
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- none atm
Rachel
- Accomplished: Updated auto-seed db script.
- Agenda topic (questions, roadblocks, help requests, topics, demo): Did I do it right???
================================================================================
CLICK HERE
================================================================================
Thad: {Heroku blockers. Manage CSS on the front end.} Aaron: Back end status.
Round robin for coding proposals, then code
- Aaron:
- Ethan:
- Merrit:
- Rachel:
- Rajinder:
- Terence:
- Thad:
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time? https://github.com/codefordc/us-congress-pizza-flag-tracker/wiki/Design-Discussion-for-App-Structure
=============================================================
(Determine order using Mob Timer) Juan:
- Accomplished: Python related starting point this week.
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- Plan (at end of meeting): Looking for issues, maybe more on frontend.
Rajinder
- Accomplished: Look things up to try to address the issue of querying the statuses into the JSON object (ORM)
- Agenda topic (questions, roadblocks, help requests, topics, demo): Trialing a line that is suppose to return a good dictionary with status details from the database ORM.
- Plan (at end of meeting): Continue to work on status obj
Thad
- Accomplished: Contacted Ananda
- Agenda topic (questions, roadblocks, help requests, topics, demo): Give flavors for Styling approach on frontend (timeboxed)
- Plan (at end of meeting): Attend Friday meeting and give a demo
Ethan
- Accomplished: Hashing passwords. PR that has better error handing on the backend (refactoring).
- Agenda topic (questions, roadblocks, help requests, topics, demo): Show the code that does the error handling. And if anyone interested, the hashing (bcrypt).
- Plan (at end of meeting): WIP: finish my pull request, table record to dict for things with objects, renew token if expires, tests, gitpod.io
Terence
- Accomplished: Backend structure is going to look like.
- Agenda topic (questions, roadblocks, help requests, topics, demo): blocked by an error on backend login
OrdersList Error: Unhandled Rejection (TypeError): Cannot read properties of undefined (reading 'status')(add ? after the word response) - Plan (at end of meeting): App structure for backend, log model
Aaron
- Accomplished: Reviewing CSS frameworks that Thad set–Emotion and Tailwind inline styling or Bootstrap/SASS to componentize the styling.
- Agenda topic (questions, roadblocks, help requests, topics, demo): Help on frontend styling effort.
- Plan (at end of meeting): Merge changes, UI changes, make responsive styling, implement UI framework
Merritt
- Accomplished:
- made improvements to React-select combo boxes (thanks to Ethan and Rachel for reviewing),
- started QR Scan update and advance screens/route
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- review Ethan's recent PR with status updates for backend
- Plan (at end of meeting):
- finish QR Scan update screen
Rachel
- Accomplished: First lines of python to make semi-random entries. Rationale for not randomizing?
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- Ethan asked not to randomize.
- Plan (at end of meeting):
- Set it so it only runs when the app is in FLASK_ENV=DEVELOPMENT and/or DEBUG mode.
Click here
- Testing data random or not?
- Stable is better by Ethan – whole idea is make it easier for the developer, if you know ahead of time, it's easier. For testing/CI, it DOES makes sense to be more random.
- Trialing a line that is suppose to return a good dictionary with status details from the database ORM.
- (merritt) review Ethan's recent PR with status updates for backend
- Give flavors for Styling approach on frontend (timeboxed)
- Show the code that does the error handling.
- And if anyone interested, the hashing (bcrypt).
Round robin for coding proposals, then code
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time? https://github.com/codefordc/us-congress-pizza-flag-tracker/wiki/Design-Discussion-for-App-Structure
Ethan - interesting, relearned about the pain of sqlalchemy to dict, next time put in comments about why Thad - excited to demo, print of sub object Merrit - good to see status getting close on the frontend Aaron - good, feels like another day in the office Rachel - good, try to get handle on AnyDesk Terence - happy, good progress - quickly reminded of dict to dict frustration, set agenda timer Rajinder - excited that Thad is going to demo, time boxing Juan - feeling more confident, kind of understanding what a python dictionary
Anyone can suggest switch topics
=============================================================
Click here and here https://github.com/codefordc/us-congress-pizza-flag-tracker/wiki/Design-Discussion-for-App-Structure
Juan:
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- Plan (at end of meeting):
Rajinder
- Accomplished:
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- Plan (at end of meeting): review ethan's pull request, refactor send status details to frontend , refactor to use util.table_xxxx function
Thad
- Accomplished:
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- Plan (at end of meeting): Work with Ananda to get answers
Ethan
- Accomplished:
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- Plan (at end of meeting): WIP: update status route and privileges and test, remove openCV, gitpod.io
Terence
- Accomplished:
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- Plan (at end of meeting): App structure for backend, log model
Aaron
- Accomplished:
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- Plan (at end of meeting): Merge changes, UI changes, make responsive styling
Merritt
- Accomplished:
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- Plan (at end of meeting):
- polish react-select, start QR Scan update screen
Rachel
- Accomplished:
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- Plan (at end of meeting): Automatically populate with orders, work with Merrit on drop downs
Juan:
- WOrked with Rajinder and Terence on sending status info to frontend Rajinder
- Accomplished: Pull request with Juan and Terence
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- Review pull request issue
- Plan (at end of meeting):
Thad
- Accomplished: Emailed Anand so can surface questions
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- Plan (at end of meeting):
Ethan
- Accomplished:
- Reviewed two pull requests
- Modified default agenda
- Added tests for authorization and route
- WIP: update status code backend with authentication and tests
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- schedule discussion on backend structure
- review pull requests comment for backend pull request
- Plan (at end of meeting):
Terence
- Accomplished:
- With Rajinder and Juan, created status actions and controllers to send a status dictionary to frontend.
- Created a document with options for BluePrints_backend Organization
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- Discussion on the BluePrints_backend Organization (See Document here)
- Plan (at end of meeting):
Aaron
- Accomplished: Changed two lines of code for logging in protected routes
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- Demo log in and code for protected routes
- Plan (at end of meeting):
Merritt
- Accomplished:
- implemented react-select comboboxes for OrderForm.js
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- demo react select
- Plan (at end of meeting):
Rachel
- Accomplished: Made friendly error message
- Agenda topic (questions, roadblocks, help requests, topics, demo):
- Plan (at end of meeting):
Click here
- Demo react select (and code?)
- Demo protected routes and code
- Review pull request for backend comments
- Discuss app structure
Round robin for coding proposals, then code
Needed: Volunteer for update status screen
Round robin wrap-up: Possible topics - How do you feel? What did you like/learn? What would you do differently next time? Rachel - Liked structure talk Juan - Liked doing Python Aaron - Feel good about how things went Rajinder - I wish I know more about JavaScript Thad - Let's do more programming on front end Merrit - Swap JavaScript for Python :-) Terence - +2 on Merritt Ethan - Glad we got through agenda, hopefully get to actual coding
- Round robin for additional items for
- demoing code (execute or show code)
- Drop-down vs Combobox UI Demo (Merritt)
- questions
- what are the levels of authorization? (Aaron)
- how does status link to a particular order? (Aaron)
- overall structure of the front end. A sitemap would be very helpfull. (Aaron)
- troubleshooting
- getting 404 errors from backend since last Friday, have tried running restart.sh (Merritt)
- cant makes calls to backend (Aaron)
- demoing code (execute or show code)
127.0.0.1 - - [25/Oct/2021 15:33:49] "←[33mPOST /undefined/api/signin HTTP/1.1←[0m" 404 -
127.0.0.1 - - [25/Oct/2021 15:34:02] "←[33mPOST /orders/undefined/api/orders/create HTTP/1.1←[0m" 404 -
-
main work project
-
other
-
Prioritize and time box
-
Discuss refactor proposal:
- create actions directory and move action files
- create controller directory, move controller files, and make controllers into classes(??) requires UI changes
- create a separate file for each model, create models directory, and move model files into model directory
- rename class files to follow Python naming conventions, e.g. OrderActions.py to order_actions.py
-
Schedule time to do the above refactoring
-
UI proposal:
- When user scans code, if user is not logged in, go to the log in screen and limit valid users where home office code starts with FED or matches the order.
- After log in, display a screen that shows the details of the orders and prompts user to change status. Status will default to the next status. List will show the previous status, current status, and next status.
- Requires a new screen on the frontend, a new route for that screen, and a route on the backend for only changing the status.
-
demo: using table_record_to_json and table_to_json (Ethan)
-
demo: mocking