-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support attaching/detaching volumes on create/update instance #341
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Vishal Anarase <[email protected]>
b410d8f
to
61610a4
Compare
Testing now, this also needs to be documented before I approved |
@@ -106,6 +106,20 @@ func ResourceInstance() *schema.Resource { | |||
Description: "An optional list of tags, represented as a key, value pair", | |||
Elem: &schema.Schema{Type: schema.TypeString}, | |||
}, | |||
"attached_volume": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be attached_volumes. Otherwise it's confusing very confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore this as the struct is just for one volume, so it is correct
No description provided.