Enable LB support #356
Open
Enable LB support #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dippydocus
reviewed
Nov 12, 2024
| Optional: true, | ||
| Description: "Firewall rules for the load balancer (e.g., 'all', '80,443', '40-80,90-120').", | ||
| }, | ||
| "backend": { |
There was a problem hiding this comment.
It is supposed to look like
resource "civo_load_balancer" "example" {
name = "uzaiii-lodbal"
# service_name = "example-service"
network_id = civo_network.example.id
algorithm = "round_robin"
external_traffic_policy = "Cluster"
session_affinity = "ClientIP"
session_affinity_config_timeout = 120
enable_proxy_protocol = "send-proxy-v2"
max_concurrent_requests = 500
firewall_id = civo_firewall.example.id
backend {
ip = "192.168.1.11"
protocol = "TCP"
source_port = 443
target_port = 8443
health_check_port = 9443
}
backend {
ip = "192.168.1.10"
protocol = "TCP"
source_port = 80
target_port = 8080
health_check_port = 9090
}
}
so since we define each backend separately so imo it should be backned, if we define all of them in a single array then it should be backends
| }, | ||
| }, | ||
| }, | ||
| "instance_pool": { |
There was a problem hiding this comment.
again the same logic as above
| name := d.Get("name").(string) | ||
|
|
||
| // Check that either backend or instance_pool is provided | ||
| backends, backendSet := d.GetOk("backend") |
|
|
||
| // Check that either backend or instance_pool is provided | ||
| backends, backendSet := d.GetOk("backend") | ||
| instancePools, instancePoolSet := d.GetOk("instance_pool") |
| d.Set("cluster_id", loadBalancer.ClusterID) | ||
| d.Set("firewall_id", loadBalancer.FirewallID) | ||
|
|
||
| fmt.Println("FIREEEE ID", loadBalancer.FirewallID) |
|
|
||
| if loadBalancer.InstancePool != nil { | ||
| flattenedInstancePool := flattenInstancePool(loadBalancer.InstancePool) | ||
| if err := d.Set("instance_pool", flattenedInstancePool); err != nil { |
| } | ||
|
|
||
| // If backend configuration has changed, update backends in the request | ||
| if d.HasChange("backend") { |
|
|
||
| // If backend configuration has changed, update backends in the request | ||
| if d.HasChange("backend") { | ||
| backends := d.Get("backend").([]interface{}) |
| } | ||
|
|
||
| // If instance pool configuration has changed, update instance pools in the request | ||
| if d.HasChange("instance_pool") { |
|
|
||
| // If instance pool configuration has changed, update instance pools in the request | ||
| if d.HasChange("instance_pool") { | ||
| instancePools := d.Get("instance_pool").([]interface{}) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.