rss: ingest atom/rss feed contents already decoding HTML special chars #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping? |
|
I think this makes sense. I'm trying to test this. |
|
@glima do you have an example of an RSS feed that exhibits this behavior that I can test? |
|
Yes, try https://kottke.org/ |
Without this move, the main UI could show info and feed entries with crude HTML marks, as in "“". Translating that at the source is the best move, since they get stored right in the DB. Signed-off-by: Gustavo Lima Chaves <[email protected]>
|
Yep, I think this makes sense and seems to work. Let's give it a shot. Thank you for the contribution @glima! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this move, the main UI could show info and feed entries with crude HTML marks, as in "“". Translating that at the source is the best move, since they get stored right in the DB.