-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements in insertImage
command, tooltip manager and mention
#17177
base: master
Are you sure you want to change the base?
Conversation
22278a5
to
c87e63b
Compare
InsertImageCommand
insertImage
command and tooltip manager
Besides the previous |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve, but as mentioned in merge fields PR, I'd consider having the "instant" tooltip also close "instantly".
Co-authored-by: Kuba Niegowski <[email protected]>
380f253
to
f9c7020
Compare
…ons with context files.
…ainst language context files.
…ated translation files.
…5-dev-translations` package.
…between packages.
…despite a pending blur timeout.
…nt and handle its focus interactions.
Tests: Introduced automated manual test sample for performance testing and data sets to test on.
…<body> to <html> to make it bulletproof.
…h-patterns Feature (mention): Allow for the mention marker to be longer than 1 character.
insertImage
command and tooltip managerinsertImage
command, tooltip manager and mention
Please use double empty lines as separators for changelog entries.
|
Feature (clipboard): Pass information to the downcast converter when clipboard pipeline is used to allow for customization. Feature (clipboard): viewToPlainText() helper will now parse the view RawElement instances.
Suggested merge commit message (convention)
Feature (image): Added a possibility to break the current block by
InsertImageCommand
withbreakBlock
flag.Feature (ui): The
.ck-with-instant-tooltip
class can now be used to display the tooltip without the delay.Feature (mention): Allow for the mention marker to be longer than 1 character.
Fix (ui): Tooltip will no longer show after quickly hovering and moving the mouse away before the tooltip shows. Closes
#16949.
Fix (ui): Tooltip will no longer disappear if cursor is moved back over the element with visible tooltip. Closes #17256.
Feature (clipboard): Pass information to the downcast converter when clipboard pipeline is used to allow for customization.
Feature (clipboard):
viewToPlainText()
helper will now parse the viewRawElement
instances.Additional information
For example – encountered issues, assumptions you had to make, other affected tickets, etc.