Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasm support #27

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Add wasm support #27

merged 1 commit into from
Mar 2, 2024

Conversation

serjsysoev
Copy link
Contributor

Recently Kotlin/Wasm reached alpha status. To add support for it, wasmJs target needs to be added. Unfortunately, this target is not available for Kotlin 1.8.0, and upgrading Kotlin compiler removes support for some targets. Previously wasmJs target was called wasm. I experimented with using wasm target instead of wasmJs and using kotlin-codepoints from a project compiled for wasmJs target, and it seems to work, so this commit adds Kotlin/Wasm support.

If deprecated targets are not important for you, I can make a PR updating Kotlin and removing unsupported architectures.

@JakeWharton
Copy link
Contributor

I would think upgrading Kotlin and updating the targets is the better play here. Otherwise you omit wasmWasi completely.

Recently Kotlin/Wasm reached alpha status. New wasmJs and wasmWasi targets are not available in Kotlin 1.8.0. To add them, this commit updates Kotlin to the latest available version (1.9.22). After Kotlin 1.8.0 some targets were deprecated, they are removed in this commit.
@serjsysoev
Copy link
Contributor Author

Updated Kotlin to 1.9.22, added wasmJs and wasmWasi targets!

@cketti cketti merged commit d143e3c into cketti:main Mar 2, 2024
1 check passed
@cketti
Copy link
Owner

cketti commented Mar 2, 2024

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants