This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Expand basecfg path earlier #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 435
💛 - Coveralls |
major
force-pushed
the
expand-basecfg-paths-early
branch
4 times, most recently
from
0e7bffd to
31d36f8
Compare
Move the path expansion for the kernel configuration file to the load_config() function. Signed-off-by: Major Hayden <[email protected]>
major
force-pushed
the
expand-basecfg-paths-early
branch
from
31d36f8 to
791cad0
Compare
|
@major , do you also need to have full path |
|
@danghai Yes, but I will put that into a different PR. |
|
@major Could I take this with this commit: danghai@5cd7c3f ? |
veruu
approved these changes
May 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanding the
basecfgpath earlier ensures that any function that uses the path to the base kernel config is getting the same absolute path to the file.Partial fix for #94.