Add warning ignore in webpack config (Fix: #734) #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#734
Following the still open cthackers/adm-zip#242, I was able to find out that the original-fs dependency is only needed for electronJS, so it's quite safe to ignore. Thanks to us being able to configure webpack as we want after the
eject, I just added the ignore through the plugins.Updating the version to the latest adm-zip (4 years of updates) didn't help, we could do this upgrade anyway, but I don't see any use just yet and we can do that in the future if needed when we have better tests for epub generation.