-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/rnd 1233 update the cpr sdk to be able to create basedocument objects #17
Merged
THOR300
merged 31 commits into
main
from
feature/rnd-1233-update-the-cpr_sdk-to-be-able-to-create-basedocument-objects
May 29, 2024
Merged
Feature/rnd 1233 update the cpr sdk to be able to create basedocument objects #17
THOR300
merged 31 commits into
main
from
feature/rnd-1233-update-the-cpr_sdk-to-be-able-to-create-basedocument-objects
May 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THOR300
force-pushed
the
feature/rnd-1233-update-the-cpr_sdk-to-be-able-to-create-basedocument-objects
branch
2 times, most recently
from
May 20, 2024 15:57
0c15f57
to
a30bfbe
Compare
THOR300
commented
May 22, 2024
… and passage level data.
…-method-not-including' into feature/rnd-1233-update-the-cpr_sdk-to-be-able-to-create-basedocument-objects Merge in the updates to the passage level parser output method.
THOR300
changed the base branch from
main
to
feature/pdct-1112-bugfix-parser-output-to-passage-level-method-not-including
May 23, 2024 08:23
… flat method call.
…rser-output-to-new-model Updating to create a BaseDocument.
…-method-not-including' into feature/rnd-1233-update-the-cpr_sdk-to-be-able-to-create-basedocument-objects Merge commit.
THOR300
commented
May 28, 2024
kdutia
approved these changes
May 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🫡
Base automatically changed from
feature/pdct-1112-bugfix-parser-output-to-passage-level-method-not-including
to
main
May 29, 2024 13:00
THOR300
deleted the
feature/rnd-1233-update-the-cpr_sdk-to-be-able-to-create-basedocument-objects
branch
May 29, 2024 13:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pull request to integrate functionality to convert from flat and passage level data in hugging face to
BaseDocument
objects.Proposed version
Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.
Visit the Semver website to understand the
difference between
MAJOR
,MINOR
, andPATCH
versions.Notes:
used -- e.g. Major > Minor > Patch
sure your selected option is marked
[x]
with no spaces in between thebrackets and the
x
Type of change
Please select the option(s) below that are most relevant:
How Has This Been Tested?
Please describe the tests that you added to verify your changes.
Before submitting
section of the
CONTRIBUTING
docs.Writing docstrings section of the
CONTRIBUTING
docs.