Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed "inheriates" to "inherits" in README #54

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

Dan-C-Reed
Copy link
Contributor

Hi there – very cool project! I believe there is a typo in the README, which I have corrected.

@clojure-finance clojure-finance requested a review from skylee03 March 5, 2024 15:00
Copy link
Collaborator

@skylee03 skylee03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The same typo also exists in our website.

I will fix them as soon as possible. If you have any other feedback, please let us know!

@skylee03 skylee03 added documentation Improvements or additions to documentation good first issue Good for newcomers labels Mar 5, 2024
@skylee03 skylee03 added this to the v1.1.1 milestone Mar 5, 2024
@skylee03 skylee03 merged commit 3f3b87c into clojure-finance:main Mar 5, 2024
1 check passed
@skylee03
Copy link
Collaborator

skylee03 commented Mar 5, 2024

I have just fixed the same typo on our website. Both you and your alt are marked as the co-authors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants