Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor project structure #27

Merged
merged 7 commits into from
Nov 29, 2023
Merged

Refactor project structure #27

merged 7 commits into from
Nov 29, 2023

Conversation

yunkon-kim
Copy link
Member

@yunkon-kim yunkon-kim commented Nov 24, 2023 •
edited
Loading

This PR will refactor and pattern the project structure.

  • Apply model-controller pattern (no view for API),
  • Add route package to bind the routes/paths of related APIs
  • Add sample API to help add new API,
  • Create Makefiles and make them relevant, and
  • Add useful samples to add new APIs.

@yunkon-kim yunkon-kim marked this pull request as ready for review November 29, 2023 09:38
@yunkon-kim
Copy link
Member Author

추후, /pkg/api/rest/model이 변경될 가능성이 있습니다. (Ref. cloud-barista/cm-honeybee#2)

seokho-son
seokho-son approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@seokho-son seokho-son merged commit f13ddac into cloud-barista:main Nov 29, 2023
4 checks passed
@yunkon-kim yunkon-kim deleted the refactor-project branch December 8, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seokho-son seokho-son seokho-son approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yunkon-kim @seokho-son