Create tasks app to make tags consistent #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/tasks/main.go
Outdated
|
|
||
| func main() { | ||
| actionPtr := flag.String("action", "", "Action to take. Accepted options: 'update-tags'") | ||
| flag.Var(&servicesToTag, "service", "Specify AWS service whose instances should have tags updated. Accepted options: 'rds'") |
There was a problem hiding this comment.
It looks like this also handles ES & Redis now — I think the description needs an update
cmd/tasks/main.go
Outdated
|
|
||
| // Load settings from environment | ||
| if err := settings.LoadFromEnv(); err != nil { | ||
| log.Fatalf("There was an error loading settings: %s", err) |
There was a problem hiding this comment.
Not necessary but one trick I thought I'd share: Write a run() function that can return an error and call run() from main(), so you can centralize top-level error handling. Example: https://github.com/cloud-gov/csb/blob/4328653379aa40e09e298c2e9015926e37a4e69b/docproxy/main.go#L208-L227
jameshochadel
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Related to cloud-gov/opensearch-boshrelease#144
Currently, old instances (RDS, Elasticache, or Elasticsearch) created by the broker before consistent tagging was introduced may not have that tagging applied to them.
This PR creates a new app, managed in
cmd/tasks, which will be used to run various one-off tasks against the broker and its instances.In particular, this PR introduces a task to update the tags for all instances to be consistent with what the broker now generates.
Things to check
INFOand debugging statements are written withlog.debugor similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.Security considerations
None. Tagging is already a feature of the broker, this script is just retroactively applying that tagging consistently to old instances. No new permissions or behaviors were added.