Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RDS enabled groups property #395

Merged
merged 12 commits into from
Dec 20, 2024
Merged

Conversation

markdboyd
Copy link
Contributor

@markdboyd markdboyd commented Dec 20, 2024

Changes proposed in this pull request:

Related to cloud-gov/opensearch-boshrelease#144

  • Add docker-compose setup for running tests locally with PostgreSQL
  • Add README docs on testing with PostgreSQL container
  • Change type of EnabledCloudWatchLogGroupExports to pq.StringArray to allow saving strings to the database. This change does require that the broker's internal database use PostgreSQL, but every other type that I tried for this field had issues saving to the database. See How to define []string in Gorm Model go-gorm/gorm#4498
  • Update test bootstrapping to allow using configured local PostgreSQL database
  • Add test for setting EnabledCloudWatchLogGroupExports when modifying an RDS database

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, just fixing issues with persisting EnabledCloudWatchLogGroupExports to the database and adding necessary test setup to catch this issue locally

@markdboyd markdboyd requested a review from a team as a code owner December 20, 2024 18:53
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@markdboyd markdboyd added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 0812b6d Dec 20, 2024
2 checks passed
@markdboyd markdboyd deleted the fix-rds-enabled-groups-property branch December 20, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants