Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Related to cloud-gov/opensearch-boshrelease#144
EnabledCloudWatchLogGroupExports
topq.StringArray
to allow saving strings to the database. This change does require that the broker's internal database use PostgreSQL, but every other type that I tried for this field had issues saving to the database. See How to define []string in Gorm Model go-gorm/gorm#4498EnabledCloudWatchLogGroupExports
when modifying an RDS databaseThings to check
INFO
and debugging statements are written withlog.debug
or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.Security considerations
None, just fixing issues with persisting
EnabledCloudWatchLogGroupExports
to the database and adding necessary test setup to catch this issue locally