Switch alert show/hide to a prop #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 29, 2024
echappen
changed the title
|
@echappen Just to check, should I be seeing messages/alerts in (If I should be testing somewhere else, just let me know.) |
|
@beepdotgov Yep, Alerts are now wrapped in aria-live regions (which are now present on page-load). So whatever text is in the alert should be the text read by the SR. You can trigger success alerts by updating roles for any user on the Manage Users page. |
This ensures that the aria-live region in the Alert component is present on page load.
echappen
force-pushed
the
eoc/531-alerts
branch
from
01d48af to
6dda1f7
Compare
|
Ach, sorry — must’ve had something cached. I see the |
beepdotgov
approved these changes
Oct 30, 2024
|
@beepdotgov Thank you for all your manual testing and collaboration on this! |
|
Thank you for doing such thoughtful research on this, @echappen. I’ve learned a lot watching you work through this issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Alertshow-hiding to a prop (this ensures that the aria-live region in the Alert component is present on page load)Related issues
Closes #531
Overrides #573
Submitter checklist
Security considerations
None, UI refactor only