Catch up main with updates from brokerpak-topic #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Required parameters should not have defaults, or user input won't be required - Defaults for optional parameters can be specified in Terraform, removing some empty default artifacts in the documentation - The identity domain cannot be updated after creation, so enforce this with `prohibit_update`
|
Creating this now so I can test the new common pipelines step added in cloud-gov/common-pipelines#142. The PR actually needs some work still. For example, removing the test field I added. |
rcgottlieb
previously approved these changes
Oct 24, 2024
I'd prefer this to be relative to each environment somehow. Will revisit.
markdboyd
reviewed
Dec 10, 2024
markdboyd
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Things to check
INFOand debugging statements are written withlog.debugor similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.Security considerations
None new.