Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log group field #13

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Fix log group field #13

merged 5 commits into from
Dec 10, 2024

Conversation

markdboyd
Copy link

Changes proposed in this pull request:

  • commit Gemfile.lock for consistency in development
  • Add logic to map log group name to log type

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, just improving the discoverability of these logs by adding a field that identifies the log type

@markdboyd markdboyd requested a review from a team as a code owner December 10, 2024 16:49
Copy link

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@markdboyd markdboyd merged commit 8e58ed6 into main Dec 10, 2024
@markdboyd markdboyd deleted the fix-log-group-field branch December 10, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants