Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update job to set default index for timeline visualizations #146

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

markdboyd
Copy link
Contributor

@markdboyd markdboyd commented Dec 11, 2024

Changes proposed in this pull request:

Fixes #145

  • update job to set default index for timeline visualizations, otherwise users get permission errors trying to visualize data from other indices which they cannot access

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

These changes do not increase permissions, they update the visualization settings to only read data from the default index where their logs are stored.

@markdboyd markdboyd requested a review from a team as a code owner December 11, 2024 16:23
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing work mark!!!

@markdboyd markdboyd merged commit a5d2be4 into main Dec 11, 2024
2 checks passed
@markdboyd markdboyd deleted the add-timeline-default-index branch December 11, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix permission issue with timeline visualizations
2 participants