Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tenant deletion on update #155

Merged
merged 13 commits into from
Dec 13, 2024
Merged

Fix tenant deletion on update #155

merged 13 commits into from
Dec 13, 2024

Conversation

markdboyd
Copy link
Contributor

Changes proposed in this pull request:

Related to #150

  • Add yq package
  • Update opensearch job pre-start script to prepare YAML configuration for tenants, roles, and role_mappings for CF orgs so that they are not deleted when securityadmin.sh runs in the post-start script

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

We are not adding new permissions or roles, just ensuring that they do not get deleted when the opensearch job restarts

@markdboyd markdboyd requested a review from a team as a code owner December 13, 2024 19:31
@markdboyd markdboyd enabled auto-merge (squash) December 13, 2024 19:34
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@markdboyd markdboyd merged commit 0bbbeca into main Dec 13, 2024
1 check passed
@markdboyd markdboyd deleted the fix-tenant-deletion-on-update branch December 13, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants