Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update logstash filters for ingestor_cloudwatch #170

Merged
merged 3 commits into from
Dec 18, 2024
Merged

update logstash filters for ingestor_cloudwatch #170

merged 3 commits into from
Dec 18, 2024

Conversation

markdboyd
Copy link
Contributor

Related to #144

Changes proposed in this pull request:

  • update logstash filters for ingestor_cloudwatch to map tag names with spaces
  • add mapping for Instance name tag
  • add index mapping for @cf.service field

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, just updating Logstash filters to accept field names with or without spaces

@markdboyd markdboyd requested a review from a team as a code owner December 18, 2024 19:45
JasonTheMain
JasonTheMain previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

JasonTheMain
JasonTheMain previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@markdboyd markdboyd enabled auto-merge (squash) December 18, 2024 19:47
JasonTheMain
JasonTheMain approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@markdboyd markdboyd merged commit 2f98e27 into main Dec 18, 2024
@markdboyd markdboyd deleted the update-ingestor-cloudwatch-filters branch December 18, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonTheMain JasonTheMain JasonTheMain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markdboyd @JasonTheMain