jwt change #69
Merged
jwt change #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengerman13
reviewed
Jun 5, 2024
| export UAA_JWKS=<%= p('opensearch-dashboards-cf-auth-proxy.uaa.jwks') %> |
There was a problem hiding this comment.
does the p() call here quote the property, too?
There was a problem hiding this comment.
I think it's the raw value. We could examine the contents of this file in the deployed VMs to be sure
There was a problem hiding this comment.
I tested it by putting a credhub value similar in dev
(dev wouldn't take ''' just stored ')
It gets rid of the ' it seems like but once i put it in the vm it works fine. so just need it to quote it
There was a problem hiding this comment.
credhub will store the quotes if you work around bash eating them:
credhub set ... -v "'"'{"keys": [...]}'}'"'"
(but this solution is good, too)
bengerman13
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Security considerations
None