Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to the latest of github.com/external-secrets/external-secrets. #10

Closed
wants to merge 16 commits into from

Conversation

SubrotoRoy
Copy link
Collaborator

Problem Statement

Updating to the latest of github.com/external-secrets/external-secrets.

Proposed Changes

Just creating a PR to include the latest commits in the main branch of github.com/external-secrets/external-secrets.

Checklist

  • I have read the contribution guidelines
  • All commits are signed with git commit --signoff
  • My changes have reasonable test coverage
  • All tests pass with make test
  • I ensured my PR is ready for review with make reviewable

rogertuma and others added 16 commits December 16, 2023 14:49
Signed-off-by: rogertuma <[email protected]>
* extra pod spec option added to helm deployment

Signed-off-by: Adrian Robotka <[email protected]>

* output of make helm.docs

Signed-off-by: Adrian Robotka <[email protected]>

---------

Signed-off-by: Adrian Robotka <[email protected]>
Signed-off-by: External Secrets Operator <[email protected]>
Co-authored-by: External Secrets Operator <[email protected]>
make it possible do deactivate processpushsecret when installing namespaced

Signed-off-by: fadecore <[email protected]>
* feat: add templating to PushSecret

Signed-off-by: Gergely Brautigam <[email protected]>

* adding unit tests around templating basic concepts and verifying output

Signed-off-by: Gergely Brautigam <[email protected]>

* extracting some of the common functions of the parser

Signed-off-by: Gergely Brautigam <[email protected]>

* remove some more duplication

Signed-off-by: Gergely Brautigam <[email protected]>

* removed commented out code segment

Signed-off-by: Gergely Brautigam <[email protected]>

* added documentation for templating feature

Signed-off-by: Gergely Brautigam <[email protected]>

* simplified the templating for annotations and labels

Signed-off-by: Gergely Brautigam <[email protected]>

---------

Signed-off-by: Gergely Brautigam <[email protected]>
Signed-off-by: External Secrets Operator <[email protected]>
Co-authored-by: External Secrets Operator <[email protected]>
Signed-off-by: Moritz Johner <[email protected]>
Bumps golang from 1.20.1 to 1.21.5.

---
updated-dependencies:
- dependency-name: golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Update cert-manager certificate duration to 1 year in the Helm chart.

This commit resolves a timing issue in the external-secrets Helm chart,
where the default certificate duration was previously not explicitly
set. This lack of specification led to conflicts with the cert-manager's
lookahead interval. By setting the `webhook.certManager.cert.duration`
to "8760h" (one year), we ensure that cert-manager will renew the
certificate before the external-secrets webhook starts to report issues,
and restarts, due to the certificate nearing expiration (as per the
lookahead interval).

This solution has been discussed in
#2519.

Signed-off-by: Thibault Gérondal <[email protected]>
@sourav977
Copy link

closing

@sourav977 sourav977 closed this Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.