Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore invalid i18n functions with valid alternatives #466

Merged

Conversation

james-elicx
Copy link
Contributor

This PR does the following:

  • Checks the build output config for i18n keys.
  • Ignores invalid functions that match those i18n keys and have a valid alternative function.
  • Adds a reason to the ignored function entries in the nop-build-log file.
  • Adds a few tests for the fix.

fixes #464 which is caused by Vercel CLI version >= 32.2.0

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2023

🦋 Changeset detected

Latest commit: 94e37e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cloudflare/next-on-pages Patch
eslint-plugin-next-on-pages Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

🧪 Prereleases are available for testing 🧪

@cloudflare/next-on-pages

You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/6236643664/npm-package-next-on-pages-466

@cloudflare/eslint-plugin-next-on-pages

You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/6236643664/npm-package-eslint-plugin-next-on-pages-466

@james-elicx james-elicx force-pushed the james/fix-invalid-i18n-fn branch from 490fbfb to 70818fd Compare September 18, 2023 20:27
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! (as always) 🤩

I just left a couple of small comments please have a look 🙂

Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! 🤩

@dario-piotrowicz dario-piotrowicz merged commit 628f6bb into cloudflare:main Sep 24, 2023
7 of 8 checks passed
@james-elicx james-elicx deleted the james/fix-invalid-i18n-fn branch September 24, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: i18n edge routes generate nodejs routes with vercel >= 32.2.0
2 participants