-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore invalid i18n functions with valid alternatives #466
fix: ignore invalid i18n functions with valid alternatives #466
Conversation
🦋 Changeset detectedLatest commit: 94e37e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🧪 Prereleases are available for testing 🧪 @cloudflare/next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/6236643664/npm-package-next-on-pages-466 @cloudflare/eslint-plugin-next-on-pagesYou can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/6236643664/npm-package-eslint-plugin-next-on-pages-466 |
490fbfb
to
70818fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff! (as always) 🤩
I just left a couple of small comments please have a look 🙂
packages/next-on-pages/src/buildApplication/processVercelFunctions/configs.ts
Show resolved
Hide resolved
packages/next-on-pages/src/buildApplication/processVercelFunctions/edgeFunctions.ts
Outdated
Show resolved
Hide resolved
...ges/next-on-pages/tests/src/buildApplication/processVercelFunctions/invalidFunctions.test.ts
Show resolved
Hide resolved
packages/next-on-pages/src/buildApplication/processVercelFunctions/invalidFunctions.ts
Outdated
Show resolved
Hide resolved
packages/next-on-pages/src/buildApplication/processVercelFunctions/invalidFunctions.ts
Show resolved
Hide resolved
…ions/edgeFunctions.ts Co-authored-by: Dario Piotrowicz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! 🤩
This PR does the following:
fixes #464 which is caused by Vercel CLI version >= 32.2.0