Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to OpenNext from next-on-pages readme #884

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

irvinebroque
Copy link

@irvinebroque irvinebroque commented Sep 29, 2024

  • Link to OpenNext adapter
  • Call out the main reasons why someone might want to consider starting with @opennextjs/cloudflare

refs cloudflare/cloudflare-docs#17196

Copy link

changeset-bot bot commented Sep 29, 2024

🦋 Changeset detected

Latest commit: b9237d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cloudflare/next-on-pages Patch
eslint-plugin-next-on-pages Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 29, 2024

🧪 Prereleases are available for testing 🧪

@cloudflare/next-on-pages

You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/11092051431/npm-package-next-on-pages-884

@cloudflare/eslint-plugin-next-on-pages

You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/11092051431/npm-package-eslint-plugin-next-on-pages-884

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
irvinebroque and others added 2 commits September 29, 2024 12:48
Comment on lines +7 to +8
> [!NOTE]
> You may want to consider using [`@opennextjs/cloudflare`](https://opennext.js.org/cloudflare), which allows you to build and deploy Next.js apps to [Cloudflare Workers](https://developers.cloudflare.com/workers/static-assets/), use [Node.js APIs](https://developers.cloudflare.com/workers/runtime-apis/nodejs/) that Cloudflare Workers supports, and enables additional Next.js features like Incremental Static Regeneration.
Copy link

@tadhglewis tadhglewis Sep 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this should say that it's the recommended method and discourage using Pages considering it will be slowly phased out 🤷

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we are quite at the place to say that @opennextjs/cloudflare is the recommended solution; it is still pre-alpha. But I agree that once it begins to stabilize, this is the message we should be sending.

Comment on lines +7 to +8
> [!NOTE]
> You may want to consider using [`@opennextjs/cloudflare`](https://opennext.js.org/cloudflare), which allows you to build and deploy Next.js apps to [Cloudflare Workers](https://developers.cloudflare.com/workers/static-assets/), use [Node.js APIs](https://developers.cloudflare.com/workers/runtime-apis/nodejs/) that Cloudflare Workers supports, and enables additional Next.js features like Incremental Static Regeneration.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we are quite at the place to say that @opennextjs/cloudflare is the recommended solution; it is still pre-alpha. But I agree that once it begins to stabilize, this is the message we should be sending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants