Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark async_hooks as external #909

Merged

Conversation

james-elicx
Copy link
Contributor

@james-elicx james-elicx commented Nov 27, 2024

fixes #908

Latest Vercel dependency broke the build because they didn't use the node prefix so we weren't accounting for it.

image

Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: 7c8766c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cloudflare/next-on-pages Patch
eslint-plugin-next-on-pages Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 27, 2024

🧪 Prereleases are available for testing 🧪

@cloudflare/next-on-pages

You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/12064688674/npm-package-next-on-pages-909

@cloudflare/eslint-plugin-next-on-pages

You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/next-on-pages/runs/12064688674/npm-package-eslint-plugin-next-on-pages-909

@james-elicx james-elicx marked this pull request as ready for review November 27, 2024 20:31
@james-elicx james-elicx force-pushed the james/async_hooks-external branch 2 times, most recently from 5432bb3 to e834348 Compare November 27, 2024 21:41
@WalshyDev WalshyDev enabled auto-merge (squash) November 27, 2024 23:26
auto-merge was automatically disabled November 28, 2024 07:54

Head branch was pushed to by a user without write access

@james-elicx james-elicx force-pushed the james/async_hooks-external branch from e834348 to 7c8766c Compare November 28, 2024 07:54
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me! thanks a lot @james-elicx!!! 🫶

@dario-piotrowicz dario-piotrowicz merged commit d879acd into cloudflare:main Nov 28, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: ERROR Could not resolve "async_hooks"
4 participants