Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix terraform clean bugs #870

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
+127 −33
Open

fix terraform clean bugs #870

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6832ddd
fix clean cmd
haitham911 Dec 19, 2024
0c90df5
feat --everything is the default behavior
haitham911 Dec 19, 2024
a2b820e
remove debug print
haitham911 Dec 19, 2024
1649cd9
Merge branch 'main' into DEV-2859
osterman Dec 19, 2024
4a9bde6
Update website/docs/cli/commands/terraform/usage.mdx
osterman Dec 26, 2024
755e5c6
Update website/docs/cli/commands/terraform/usage.mdx
osterman Dec 26, 2024
13126b2
Apply suggestions from code review
osterman Dec 26, 2024
7e2f054
Update internal/exec/help.go
osterman Dec 26, 2024
f4a81b3
Merge branch 'main' into DEV-2859
osterman Dec 26, 2024
8d1292b
Merge branch 'main' into DEV-2859
haitham911 Jan 4, 2025
1acd1d0
remove --everything
haitham911 Jan 4, 2025
338d859
add integration test for terraform apply and terraform clean
haitham911 Jan 4, 2025
6735525
chang dev with prod
haitham911 Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions internal/exec/terraform.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,10 @@ func ExecuteTerraform(info schema.ConfigAndStacksInfo) error {
shouldCheckStack := true
// Skip stack processing when cleaning with --everything or --force flags to allow
// cleaning without requiring stack configuration
if info.SubCommand == "clean" &&
(u.SliceContainsString(info.AdditionalArgsAndFlags, everythingFlag) ||
u.SliceContainsString(info.AdditionalArgsAndFlags, forceFlag)) {
if info.SubCommand == "clean" {
if info.ComponentFromArg == "" {
shouldProcessStacks = false
}

shouldCheckStack = info.Stack != ""

}
Expand All @@ -96,7 +93,7 @@ func ExecuteTerraform(info schema.ConfigAndStacksInfo) error {
}
}

if !info.ComponentIsEnabled {
if !info.ComponentIsEnabled && info.SubCommand != "clean" {
u.LogInfo(atmosConfig, fmt.Sprintf("component '%s' is not enabled and skipped", info.ComponentFromArg))
return nil
}
Expand Down
Loading