Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add demo workflow #872
base: main
Are you sure you want to change the base?
Add demo workflow #872
Changes from 66 commits
e0d4b39
75ae8d8
69cb6f0
9e0777a
9062468
2600a6f
2bbedb9
8a2c86e
63c62ca
1e55e9d
1fe7ffa
e838a8a
a80687a
1df005f
806317c
d27fceb
6b30d09
1471ae2
e77df1d
08673a8
a529cea
3031aa0
4f486b1
ef49fc9
09d0558
e0b4781
e1f5109
65608d2
c22cfb8
62a9a70
957aad4
3e92700
97ff562
6f1ce5b
4d84db3
f9d23b3
6cafabf
df2782a
07390f8
cb688d9
bddcb50
513c8e2
6c63877
81eb5ee
aa6599d
2047d8e
d859b4b
f161810
3d15df5
b868732
880c3e0
a1e2006
3195b0a
73a8c1b
67e5fff
5793749
1339e56
0ab6e38
3a0dccd
dedf76c
ce2bff7
bd5cafd
1856da7
33956c4
e7c8db4
d9245a4
dc6a905
f285b78
1dfde36
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add error handling to package installation.
The dependency installation step should verify that all required packages are installed successfully.
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Pin the set-swap-space action to a specific version.
Using a commit SHA for the action version is not recommended. Use a proper version tag instead.
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add error handling to screencast recording.
The recording step needs proper error handling and validation.
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add proper quoting to GitHub step summary commands.
The GITHUB_STEP_SUMMARY environment variable needs proper quoting.
Also applies to: 156-157
🧰 Tools
🪛 actionlint (1.7.4)
150-150: shellcheck reported issue in this script: SC2086:info:1:23: Double quote to prevent globbing and word splitting
(shellcheck)
150-150: shellcheck reported issue in this script: SC2086:info:2:151: Double quote to prevent globbing and word splitting
(shellcheck)
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Handle missing dependencies gracefully.
You rely on git, vhs, and ffmpeg. Consider adding checks to confirm these tools are installed, providing clearer error messaging if missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add error handling around the vhs command.
If the
vhs
invocation fails, consider exiting early with an informative message to prevent subsequent steps from running on partial output.