Handles SIGINT (Ctr-C) and gracefully stops an inflight request. #134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently spanner-cli doesn't handle
SIGINT
, so if it receivesSIGINT
in response to theCtrl-C
, the CLI is killed suddenly and inflight request is not canceled properly.This PR handles the
SIGINT
properly for both interactive mode and batch mode. This PR also removes theSession.ctx
field, which was not used effectively at this moment.More background: #133
Example
Interactive mode
Batch mode