Skip to content

Commit

Permalink
Merge pull request #25 from clue-labs/php8.4
Browse files Browse the repository at this point in the history
Run tests on PHP 8.4 and update test environment
  • Loading branch information
clue authored Dec 7, 2024
2 parents d686670 + b84f093 commit f1bd5df
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 19 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@ on:
jobs:
PHPUnit:
name: PHPUnit (PHP ${{ matrix.php }})
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
strategy:
matrix:
php:
- 8.4
- 8.3
- 8.2
- 8.1
Expand Down Expand Up @@ -38,7 +39,7 @@ jobs:

PHPUnit-hhvm:
name: PHPUnit (HHVM)
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
continue-on-error: true
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ composer install
To run the test suite, go to the project root and run:

```bash
php vendor/bin/phpunit
vendor/bin/phpunit
```

## License
Expand Down
20 changes: 10 additions & 10 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,6 @@
"email": "[email protected]"
}
],
"autoload": {
"psr-4": {
"Clue\\React\\Multicast\\": "src/"
}
},
"autoload-dev": {
"psr-4": {
"Clue\\Tests\\React\\Multicast\\": "tests/"
}
},
"require": {
"php": ">=5.3",
"react/datagram": "^1.10",
Expand All @@ -31,5 +21,15 @@
},
"suggest": {
"ext-sockets": "Requires PHP 5.4+ and the low level socket API for listening on multicast addresses (socket options to send IGMP announcements)"
},
"autoload": {
"psr-4": {
"Clue\\React\\Multicast\\": "src/"
}
},
"autoload-dev": {
"psr-4": {
"Clue\\Tests\\React\\Multicast\\": "tests/"
}
}
}
7 changes: 1 addition & 6 deletions src/Factory.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,7 @@ class Factory
* This value SHOULD NOT be given unless you're sure you want to explicitly use a
* given event loop instance.
*
* ```php
* $loop = React\EventLoop\Factory::create();
* $factory = new Factory($loop);
* ```
*
* @param LoopInterface $loop
* @param ?LoopInterface $loop
*/
public function __construct($loop = null)
{
Expand Down

0 comments on commit f1bd5df

Please sign in to comment.