Ceph Stats #8
Merged
Ceph Stats #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arttor
approved these changes
Dec 2, 2024
| int32 election_epoch = 3; | ||
| repeated int32 quorum = 4; | ||
| repeated string quorum_names = 5; | ||
| int32 quorum_age = 6; |
There was a problem hiding this comment.
so in this context epoch and age is not time but some internal ceph sequence, right? And we cannot convert it to timestamps?
There was a problem hiding this comment.
election epoch is a sequence used to track the number of elections that have occured, and quorum age is the number of seconds passed since the quroum has been stable both can be represented as integer, not sure weather quorums can be stable for more than the upper limit of int32 in go....
There was a problem hiding this comment.
to be on the safe side we can just upgrade all int32 variables to int64?
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ceph status service which runs the "ceph status" command and returns its output.