Ceph Mon Dump #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arttor
requested changes
Dec 9, 2024
api/status.proto
Outdated
| int32 epoch = 1; | ||
| string fsid = 2; | ||
| string modified = 3; | ||
| string created = 4; |
There was a problem hiding this comment.
could it be a timestamp (same question for modified)?
There was a problem hiding this comment.
{"modified": "2024-10-07T12:56:12.682935Z", "created": "2024-10-07T12:56:10.723433Z",}
All of them are in this format, not sure if this is how we can serialize in grpc
There was a problem hiding this comment.
i think that it is worth to parce string to Go time.Time and then pass it to grpc timestamp. what do you think?
There was a problem hiding this comment.
It's possible but would involve making a new struct and converting it to the grpc response seems worth it though.
shutstart
force-pushed
the
feat/ceph-mon-dump
branch
from
39a4e31 to
6d190c8
Compare
arttor
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the endpoint to execute the
ceph-mon-dumpcommand to the ceph-api.