Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GEM] Allow storing 2025 geometry in GEMGeometryParsFromDD #47007

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Geometry/GEMGeometryBuilder/src/GEMGeometryParsFromDD.cc
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,9 @@ void GEMGeometryParsFromDD::buildGeometry(DDFilteredView& fv,
fvGE2.parent();
fvGE2.parent();
// in 2021 we have 1 demonstrator chamber in 2024 we have 3 chambers.
// in 2025 we have 7 chambers.
// Need to account for both
doSuper = (nGE21 < 4 && fvGE2.nextSibling());
doSuper = (nGE21 < 8 && fvGE2.nextSibling());
} else {
edm::LogError("GEMGeometryParsFromDD") << "Failed to find next child volume. Cannot determine presence of GE 2/1";
}
Expand Down