Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make implicit copy of TrackingRecHitsSoACollection<TrackerTraits> to host asynchronous #47035

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Jan 2, 2025

PR description:

This PR is a follow-up to #45743 by making the implicit copy-to-host operation of TrackingRecHitsSoACollection<TrackerTraits> asynchronous, as planned in #45708 (comment) and #45708 (comment) (using the functionality added in #45801)

Resolves cms-sw/framework-team#1128

PR validation:

Unit tests pass on nodes with and without NVIDIA GPU

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 2, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 2, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 2, 2025

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • DataFormats/TrackingRecHitSoA (reconstruction, heterogeneous)

@cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen can you please review it and eventually sign? Thanks.
@VinInn, @VourMa, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Jan 2, 2025

enable gpu

@makortel
Copy link
Contributor Author

makortel commented Jan 2, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 2, 2025

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53b8b2/43616/summary.html
COMMIT: a72babc
CMSSW: CMSSW_15_0_X_2025-01-02-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47035/43616/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

@jfernan2
Copy link
Contributor

jfernan2 commented Jan 3, 2025

+1

@fwyzard
Copy link
Contributor

fwyzard commented Jan 3, 2025

+heterogeneous

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b569e4a into cms-sw:master Jan 5, 2025
14 checks passed
@makortel makortel deleted the trackingRecHitsSoACollectionAsync branch January 6, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make implicit copy of TrackingRecHitsSoACollection<TrackerTraits> to host asynchronous
5 participants