Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commented-out putenv() calls from SiPixelFedCablingMapWriter #47040

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Jan 3, 2025

PR description:

Identified as part of #46002 (comment). Removing the commented-out part makes it easier to not get false positives with searches like git grep.

Resolves cms-sw/framework-team#1143

PR validation:

Code compiles

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2025

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • CalibTracker/SiPixelConnectivity (alca)

@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks.
@dkotlins, @ferencek, @mmusich, @mroguljic, @rsreds, @tocheng, @tsusa, @tvami, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Jan 3, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2025

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe6864/43621/summary.html
COMMIT: 562c81d
CMSSW: CMSSW_15_0_X_2025-01-03-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47040/43621/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

perrotta commented Jan 4, 2025

+alca

  • Just removing already commented out lines (since Jan 2016)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 4, 2025

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit be3a36e into cms-sw:master Jan 5, 2025
11 checks passed
@makortel makortel deleted the removeCommentedPutenv branch January 6, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove commented-out calls to putenv
4 participants