Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: RelNode/RexNode (PlanNode/PredNode) separation + more refactors #223

Merged
merged 29 commits into from
Nov 7, 2024
Merged

refactor: RelNode/RexNode (PlanNode/PredNode) separation + more refactors #223

merged 29 commits into from
Nov 7, 2024

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Nov 6, 2024

please rebase + merge

skyzh and others added 10 commits November 5, 2024 18:20
@skyzh @jurplel
refactor(adv-cost): adapt to new plannode (#223)
2082152 
Co-Authored-By: Benjamin O <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
@skyzh @jurplel
refactor(df-repr): base cost derives pred cost (#223)
be640c4 
Co-Authored-By: Benjamin O <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
@jurplel @skyzh
refactor(df-repr): predicate compiles (#223)
37cb7e1 
Co-Authored-By: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
@skyzh @jurplel
refactor(df-repr): properties compiles (#223)
cc1a530 
Co-Authored-By: Benjamin O <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
@jurplel @skyzh
refactor(df-repr): plan node compiles (#223)
616aead 
Co-Authored-By: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
@jurplel @skyzh
refactor(core): rule engine support predicates (#223)
62df5a0 
Co-Authored-By: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
@skyzh @jurplel
refactor(df-repr): support explain (#223)
0d0615b 
Co-Authored-By: Benjamin O <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
@skyzh
fix(core): memo table tests, enable predicate lookup (#223)
497a77f 
Signed-off-by: Alex Chi <[email protected]>
@skyzh
fix(df-repr): pass all tests (#223)
ef5f863 
Signed-off-by: Alex Chi <[email protected]>
@jurplel @skyzh
refactor(df-bridge): compiles, and fix bugs in other crates (#223)
6714ba4 
Co-Authored-By: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
@skyzh
Copy link
Member Author

skyzh commented Nov 6, 2024

... and need to rewrite the history to include coauthors

@skyzh @jurplel
fix(df-repr): column ref property (#223)
ad7cb6b 
Co-Authored-By: Benjamin O <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
@skyzh skyzh force-pushed the optd-refactor branch 2 times, most recently from 8133e39 to 0a0d9e0 Compare November 6, 2024 03:57
skyzh added a commit that referenced this pull request Nov 6, 2024
@skyzh @jurplel
refactor(gungnir): use new plannode (#223)
e7e092c 
Co-Authored-By: Benjamin O <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 6, 2024
@skyzh @jurplel
refactor(adv-cost): adapt to new plannode (#223)
b68c50a 
Co-Authored-By: Benjamin O <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 6, 2024
@skyzh @jurplel
refactor(df-repr): base cost derives pred cost (#223)
03642ce 
Co-Authored-By: Benjamin O <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 6, 2024
@jurplel @skyzh
refactor(df-repr): predicate compiles (#223)
1f0ea33 
Co-Authored-By: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 6, 2024
@skyzh @jurplel
refactor(df-repr): properties compiles (#223)
9113c86 
Co-Authored-By: Benjamin O <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 6, 2024
@jurplel @skyzh
refactor(df-repr): plan node compiles (#223)
97590ac 
Co-Authored-By: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 6, 2024
@jurplel @skyzh
refactor(core): rule engine support predicates (#223)
32cbb5a 
Co-Authored-By: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 6, 2024
@skyzh @jurplel
refactor(df-repr): support explain (#223)
1f51f9a 
Co-Authored-By: Benjamin O <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 6, 2024
@skyzh
fix(core): memo table tests, enable predicate lookup (#223)
b12aacb 
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 6, 2024
@skyzh
fix(df-repr): pass all tests (#223)
f5261e3 
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 6, 2024
@jurplel @skyzh
refactor(df-bridge): compiles, and fix bugs in other crates (#223)
3676e49 
Co-Authored-By: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 6, 2024
@skyzh @jurplel
fix(df-repr): column ref property (#223)
96cbeba 
Co-Authored-By: Benjamin O <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 6, 2024
@skyzh
refactor(core): simplify rule engine (#223)
83a6808 
Signed-off-by: Alex Chi <[email protected]>
@skyzh skyzh deleted the optd-refactor branch November 7, 2024 23:08
skyzh added a commit that referenced this pull request Nov 7, 2024
@jurplel @skyzh
refactor(core): expose group information in plan node (#223)
8e3204f 
Co-Authored-By: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh @jurplel
refactor(gungnir): use new plannode (#223)
fb13089 
Co-Authored-By: Benjamin O <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh @jurplel
refactor(adv-cost): adapt to new plannode (#223)
85e6546 
Co-Authored-By: Benjamin O <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh @jurplel
refactor(df-repr): base cost derives pred cost (#223)
03f397e 
Co-Authored-By: Benjamin O <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@jurplel @skyzh
refactor(df-repr): predicate compiles (#223)
8689f0c 
Co-Authored-By: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh @jurplel
refactor(df-repr): properties compiles (#223)
1b9b720 
Co-Authored-By: Benjamin O <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@jurplel @skyzh
refactor(df-repr): plan node compiles (#223)
ec10f84 
Co-Authored-By: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@jurplel @skyzh
refactor(core): rule engine support predicates (#223)
d19fdd9 
Co-Authored-By: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh @jurplel
refactor(df-repr): support explain (#223)
538544a 
Co-Authored-By: Benjamin O <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh
fix(core): memo table tests, enable predicate lookup (#223)
b51faca 
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh
fix(df-repr): pass all tests (#223)
82ecbe3 
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@jurplel @skyzh
refactor(df-bridge): compiles, and fix bugs in other crates (#223)
d1543dc 
Co-Authored-By: Alex Chi <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh @jurplel
fix(df-repr): column ref property (#223)
cc06ea4 
Co-Authored-By: Benjamin O <[email protected]>
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh
refactor(core): simplify rule engine (#223)
0069026 
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh
fix(df-repr): join commute rule needs cross->inner, more logging when…
5df8dd1 
… apply rule (#223)

Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh
feat(df-repr): add optimizer ext for easier access to properties (#223)
1cd52c5 
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh
feat(df-repr): enable hash-join and join-assoc rule (#223)
4b4e847 
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh
fix(df-repr): enable project merge and project elimination rule (#223)
7d74fd5 
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh
fix(df-repr): enable eliminate limit rule (#223)
147db38 
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh
fix(df-repr): enable filter rules (#223)
77187df 
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh
fix(df-repr): enable subquery rules (#223)
35835b9 
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh
fix(df-repr): enable projection rules (#223)
748031b 
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh
fix(core): clippy warnings (#223)
8b8ac88 
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh
refactor(adv-cost): compiles and not rely on opt ctx (#223)
72480c6 
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh
fix(adv-cost): clippy warnings (#223)
c529130 
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh
feat(df-repr): implement display for properties (#223)
5f8c323 
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh
feat(core): dump predicates when dumping the memo table (#223)
4328943 
Signed-off-by: Alex Chi <[email protected]>
skyzh added a commit that referenced this pull request Nov 7, 2024
@skyzh
feat(plannertest): add disable pruning and dump memo flags (#223)
4fec4eb 
Signed-off-by: Alex Chi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurplel jurplel jurplel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skyzh @jurplel