Extra decimal support for TPC-H Q18 #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurplel
changed the title
jurplel
changed the title
jurplel
changed the title
jurplel
added a commit
that referenced
this pull request
Dec 10, 2024
- Support uncorrelated/correlated IN (ANY) and EXISTS clauses (This should effectively make subquery unnesting feature complete!) - TPC-H Q4, Q16, Q20, and Q22 working - The remaining queries mostly seem to have plans that are too bad (Q18 has some other issue, [fix in the pipeline](#261) but it still seems like the plan is too slow).
jurplel
force-pushed
the
bowad/tpch-q18-attempt
branch
from
7b2b2b1 to
225753d
Compare
skyzh
approved these changes
Dec 11, 2024
| @@ -211,7 +211,16 @@ impl Value { | |||
| } | |||
| _ => panic!("{self} could not be converted into an Date32"), | |||
| }), | |||
| _ => unimplemented!("Have not implemented convert_to_type for DataType {typ}"), | |||
| DataType::Decimal128(_, _) => Value::Decimal128(match self { | |||
| // TODO: Should we be ignoring the scale and precision here? | |||
There was a problem hiding this comment.
I think Postgres has a set of rules to determine decimal in this case but let's ignore it for now...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regrettably the query is still too slow...
Would like a sanity check on this in any case.
Won't merge until unnest-exists is merged