-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Eliminate Limit Rule #60
Conversation
I am not sure how to construct a query that will test this case:
any ideas? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. I think for testing skip=0 and fetch is none datafusion repo creates fake logical plan with limit as the children node of the limit. If we want to do the same testing using sql, we might need to add support for subqueries or unions or other complicated nested queries to get this internal states...
Not sure if current optd can support things like |
I'll go ahead and merge this for now but let me know if we have a nice way to test with fabricated query plans. |
Depends on #58