Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated oci and qualified-device APIs #218

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Remove deprecated oci and qualified-device APIs #218

merged 2 commits into from
Aug 8, 2024

Conversation

bart0sh
Copy link
Contributor

@bart0sh bart0sh commented Aug 8, 2024

partial fix for #206

@bart0sh bart0sh requested review from elezar and klihub August 8, 2024 13:50
@bart0sh
Copy link
Contributor Author

bart0sh commented Aug 8, 2024

@klihub @elezar I left registry APIs intact as they require a bit more work. I'd prefer to remove them in a separate PR.

@elezar elezar mentioned this pull request Aug 8, 2024
Open
18 tasks
elezar
elezar requested changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bart0sh.

I have a minor comment on moving the tests.

Also, let's remove the two sets of fuctions in separate commits.

pkg/cdi/qualified-device_test.go Outdated Show resolved Hide resolved
@bart0sh bart0sh force-pushed the PR019-remove-deprecated-APIs branch from f3e930b to dc33711 Compare August 8, 2024 14:48
elezar
elezar reviewed Aug 8, 2024
View reviewed changes
specs-go/oci.go Outdated Show resolved Hide resolved
@bart0sh bart0sh force-pushed the PR019-remove-deprecated-APIs branch from dc33711 to 78c9936 Compare August 8, 2024 15:00
@elezar elezar merged commit 39d5eb5 into cncf-tags:main Aug 8, 2024
7 checks passed
klihub
klihub approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klihub klihub klihub approved these changes

@elezar elezar elezar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bart0sh @elezar @klihub