sortMounts stable and remove alphabetical order #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhuyiqing.wiz <[email protected]>
elezar
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Thanks @Epsilon314
What is the expected behaviour when the mount being injected has:
- the same number of parts
- a greater number of parts
The behaviour for 1 seems undefined and was the motivation for the alphabetical sorting in the first place.
|
@elezar For mounts with same number of parts, its original order will be kept (stable sort). Since containerd also uses stable sort, users can therefore arrange the order of their mounts (of same number of parts ) in container spec if they do need a specific order. |
|
Ok, so if we add mounts these would always be added after the existing mounts. Could you add tests for those cases? |
Signed-off-by: zhuyiqing.wiz <[email protected]>
@elezar OK |
elezar
approved these changes
Nov 21, 2024
klihub
approved these changes
Nov 25, 2024
bart0sh
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #240