feat: Env vars from query #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hrk091
commented
Dec 12, 2023
| conf.eventAbbr = vars.eventAbbr | ||
| } | ||
| if (vars.transTimePage1) { | ||
| conf.transTimePage1 = parseFloat(vars.transTimePage1) |
There was a problem hiding this comment.
@Gaku-Kunimi
元々parseIntを使っていて小数点以下が破棄されていたのを、parseFloatに直したので、 #14 が直っているかもしれません。
|
menu画面から各幕間ページに行くときに、query parameterが維持されるようにしました |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
環境変数で指定している値を、全てquery stringからoverrideできるようにしました。
NEXT_PUBLIC_XXX となっている場合、XXXの部分をcamelCaseにしてqueryに追加してもらえたら、overrideできます。
debugだけではなく、excludedTalks や transTimePageX の差し替えなどもできます。
CNDT2023で必須の修正ではないと思うので、カンファレンスが終わった後でmergeでも良さそうです。