Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ "same as" relationship support #71

Open
wants to merge 7 commits into
base: devel
Choose a base branch
from
Open

✨ "same as" relationship support #71

wants to merge 7 commits into from

Conversation

bunop
Copy link
Member

@bunop bunop commented Oct 29, 2019

Description

  • model same as relationship into database and views
  • submit data to BioSamples with the same as relationship

Related Issue

closes #70

Motivation and Context

This PR support the same as relationship between an InjectTool record and an already Submitted BioSamples ID (not submitted by InjectTool)

How Has This Been Tested?

This was tested with UnitTest and by submitting data to BioSamples test servers

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change which improve code itself)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bunop
Copy link
Member Author

bunop commented Nov 18, 2019

validation/tests/test_helpers.py::SubmissionTestCase::test_animal test fails with
['Warning: Fail to retrieve record SAMEA4450079 from BioSamples as required in the relationship for Record ANIMAL:::ID:::132713']. Why? mock up this

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 97.926% when pulling c47bee2 on issue-70 into 659f48c on devel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants