Skip to content

Commit

Permalink
feature: Document ignore security findings feature [TAROT-2883]
Browse files Browse the repository at this point in the history
  • Loading branch information
afsmeira committed Oct 23, 2024
1 parent 307fcd7 commit fa95333
Show file tree
Hide file tree
Showing 5 changed files with 37 additions and 0 deletions.
7 changes: 7 additions & 0 deletions docs/organizations/audit-logs-for-organizations.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,3 +80,10 @@ The sections below list the events that Codacy logs for your organization at use
| Update quality settings for repository | Update quality settings for repository |`repositories.settings.quality.repository.update`|
| Update quality settings for pull requests | Update quality settings for pull requests |`repositories.settings.quality.pullrequests.update`|
| Update file state | Ignore or Unignore file |`repositories.file.update`|

### Security and Risk Management

|Event|Description|Action|
|-----|-----------|------|
|Ignore security finding|Security finding was ignored|`srm.finding.ignore`|
|Unignore security finding|Security finding was unignored|`srm.finding.unignore`|

Check failure on line 89 in docs/organizations/audit-logs-for-organizations.md

View workflow job for this annotation

GitHub Actions / vale

[vale] reported by reviewdog 🐶 [Vale.Spelling] Did you really mean 'Unignore'? Raw Output: {"message": "[Vale.Spelling] Did you really mean 'Unignore'?", "location": {"path": "docs/organizations/audit-logs-for-organizations.md", "range": {"start": {"line": 89, "column": 2}}}, "severity": "ERROR"}

Check failure on line 89 in docs/organizations/audit-logs-for-organizations.md

View workflow job for this annotation

GitHub Actions / vale

[vale] reported by reviewdog 🐶 [Vale.Spelling] Did you really mean 'unignored'? Raw Output: {"message": "[Vale.Spelling] Did you really mean 'unignored'?", "location": {"path": "docs/organizations/audit-logs-for-organizations.md", "range": {"start": {"line": 89, "column": 49}}}, "severity": "ERROR"}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
30 changes: 30 additions & 0 deletions docs/organizations/managing-security-and-risk.md
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,36 @@ To share the current view of the overview or findings page, click the **Copy URL

!!! Important " [**Segments**](../segments) filter won't be considered when sharing the filtered view"

## Ignoring findings {: id="ignoring-findings"}

!!! info "This feature is available only to organization admins and organization managers"

In the findings details page, it is possible to ignore it using the context menu. When ignoring an issue you can optionally specify a reason for doing so.

Check failure on line 113 in docs/organizations/managing-security-and-risk.md

View workflow job for this annotation

GitHub Actions / vale

[vale] reported by reviewdog 🐶 [Microsoft.Contractions] Use 'it's' instead of 'it is'. Raw Output: {"message": "[Microsoft.Contractions] Use 'it's' instead of 'it is'.", "location": {"path": "docs/organizations/managing-security-and-risk.md", "range": {"start": {"line": 113, "column": 31}}}, "severity": "ERROR"}

![Security and risk management finding ignore](images/security-risk-management-finding-ignore.png)

From an organization standpoint, ignoring a finding means that you accept the risk it poses and you're not planning on adressing the issue.

Check failure on line 117 in docs/organizations/managing-security-and-risk.md

View workflow job for this annotation

GitHub Actions / vale

[vale] reported by reviewdog 🐶 [Vale.Spelling] Did you really mean 'adressing'? Raw Output: {"message": "[Vale.Spelling] Did you really mean 'adressing'?", "location": {"path": "docs/organizations/managing-security-and-risk.md", "range": {"start": {"line": 117, "column": 120}}}, "severity": "ERROR"}

From Codacy's standpoint, ignoring a finding means it will be removed from the metrics featured in the [overview page](#dashboard) page. Note that the [Open Findings history](#open-findings-history) chart will only be changed at the start of next week.

!!! info [Jira](./integrations/jira-integration.md) findings can't be ignored in Codacy. You should closed the issue directly in Jira.

!!! warn Ignoring findings detected on [Git repositories](#how-codacy-manages-findings-detected-on-git-repositories--idopening-and-closing-codacy-items) will also [ignore the issue at the repository level](../repositories/issues.md#ignoring-and-managing-issues).

You can still see **Ignored** findings in the [findings list](#findings--iditem-list), by filtering for the **Ignored** status in the **Status** dropdown. Check the **Status** column to know the status of a finding.

![Security and risk management finding unignore list](images/security-risk-management-finding-unignore-list.png)

Check failure on line 127 in docs/organizations/managing-security-and-risk.md

View workflow job for this annotation

GitHub Actions / vale

[vale] reported by reviewdog 🐶 [Vale.Spelling] Did you really mean 'unignore'? Raw Output: {"message": "[Vale.Spelling] Did you really mean 'unignore'?", "location": {"path": "docs/organizations/managing-security-and-risk.md", "range": {"start": {"line": 127, "column": 40}}}, "severity": "ERROR"}

An Ignored finding can be **unignored** directly from the [findings list](#findings--iditem-list) or by going to the same menu where the ignore action was performed, in the findings details page. Note that in this panel you can also find out more about who ignored the issue and why, if such a reason was provided.

Unignoring a finding reverts the effects of ignoring it.

Check failure on line 131 in docs/organizations/managing-security-and-risk.md

View workflow job for this annotation

GitHub Actions / vale

[vale] reported by reviewdog 🐶 [Vale.Spelling] Did you really mean 'Unignoring'? Raw Output: {"message": "[Vale.Spelling] Did you really mean 'Unignoring'?", "location": {"path": "docs/organizations/managing-security-and-risk.md", "range": {"start": {"line": 131, "column": 1}}}, "severity": "ERROR"}

![Security and risk management finding unignore](images/security-risk-management-finding-unignore.png)

Check failure on line 133 in docs/organizations/managing-security-and-risk.md

View workflow job for this annotation

GitHub Actions / vale

[vale] reported by reviewdog 🐶 [Vale.Spelling] Did you really mean 'unignore'? Raw Output: {"message": "[Vale.Spelling] Did you really mean 'unignore'?", "location": {"path": "docs/organizations/managing-security-and-risk.md", "range": {"start": {"line": 133, "column": 40}}}, "severity": "ERROR"}

!!! warn Unignoring findings detected on [Git repositories](#how-codacy-manages-findings-detected-on-git-repositories--idopening-and-closing-codacy-items) will also [unignore the issue at the repository level](../repositories/issues.md#ignoring-and-managing-issues).

Check failure on line 135 in docs/organizations/managing-security-and-risk.md

View workflow job for this annotation

GitHub Actions / vale

[vale] reported by reviewdog 🐶 [Vale.Spelling] Did you really mean 'Unignoring'? Raw Output: {"message": "[Vale.Spelling] Did you really mean 'Unignoring'?", "location": {"path": "docs/organizations/managing-security-and-risk.md", "range": {"start": {"line": 135, "column": 10}}}, "severity": "ERROR"}

Check failure on line 135 in docs/organizations/managing-security-and-risk.md

View workflow job for this annotation

GitHub Actions / vale

[vale] reported by reviewdog 🐶 [Vale.Spelling] Did you really mean 'unignore'? Raw Output: {"message": "[Vale.Spelling] Did you really mean 'unignore'?", "location": {"path": "docs/organizations/managing-security-and-risk.md", "range": {"start": {"line": 135, "column": 167}}}, "severity": "ERROR"}

!!! info Ignoring and unignoring findings are [auditable actions](../organizations/audit-logs-for-organizations.md#security-and-risk-management).

## Exporting findings {: id="exporting-the-security-item-list"}

!!! info "This feature is available only to organization admins and organization managers"
Expand Down

0 comments on commit fa95333

Please sign in to comment.