Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump markdown from 3.3.7 to 3.5 #1884

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 9, 2023

Bumps markdown from 3.3.7 to 3.5.

Changelog

Sourced from markdown's changelog.

[3.5] -- 2023-10-06

Added

Add permalink_leading configuration option to the toc extension (#1339)

A new boolean option permalink_leading controls the position of the permanent link anchors generated with permalink. Setting permalink_leading to True will cause the links to be inserted at the start of the header, before any other header content. The default behavior for permalink is to append permanent links to the header, placing them after all other header content.

Changed

  • Add support for cPython version 3.12 (and PyPy 3.10) and drop support for Python version 3.7 (#1357).
  • Refactor changelog to use the format defined at https://keepachangelog.com/.
  • Update the list of empty HTML tags (#1353).
  • Add customizable TOC title class to TOC extension (#1293).
  • Add API documentation of the code base which is generated by mkdocstrings (#1220).

Fixed

  • Fix a corner case in admonitions where if an indented code block was provided as the first block, the output would be malformed (#1329).

[3.4.4] -- 2023-07-25

Fixed

  • Add a special case for initial 's to smarty extension (#1305).
  • Unescape any backslash escaped inline raw HTML (#1358).
  • Unescape backslash escaped TOC token names (#1360).

[3.4.3] -- 2023-03-23

Fixed

  • Restore console script (#1327).

[3.4.2] -- 2023-03-22

Added

  • Officially support Python 3.11.

Fixed

  • Improve standalone * and _ parsing (#1300).

... (truncated)

Commits
  • f50ac47 Refactor changelog
  • 6662053 TOC extension: Add new boolean option permalink_prepend (#1339)
  • f99f176 Bump version to 3.4.4
  • ff88261 Unescape backslash escaped TOC token names
  • d60c16f Unescape any backslash escaped inline raw HTML
  • 93054dd Fix XML deprecations
  • dba8025 smarty: Add a special case for 's at the beginning of the token
  • 07b8b2c Use pyspelling to check spelling.
  • c0faf52 Restore console script.
  • 6a85e4d Bump version to 3.4.2
  • Additional commits viewable in compare view

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
markdown [>= 3.4.a, < 3.5]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [markdown](https://github.com/Python-Markdown/markdown) from 3.3.7 to 3.5.
- [Changelog](https://github.com/Python-Markdown/markdown/blob/master/docs/changelog.md)
- [Commits](Python-Markdown/markdown@3.3.7...3.5)

---
updated-dependencies:
- dependency-name: markdown
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner October 9, 2023 03:02
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Oct 9, 2023
@github-actions github-actions bot temporarily deployed to Netlify October 9, 2023 11:09 Inactive
requirements.txt Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to Netlify October 9, 2023 12:00 Inactive
@nicklem
Copy link
Contributor

nicklem commented Oct 9, 2023

We temporarily pinned this to a lower version for a reason unclear to me ATM.

We already unpinned the version on the Pulse user docs (codacy/pulse-user-docs#244), but the setup is slightly different there.

Before we merge this one, I'd rather double-check to confirm that we're not breaking anything.

Copy link
Contributor

@claudiacarpinteiro claudiacarpinteiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I navigated around and everything looks good to me. 👍
I'm approving it, but let me know if there is any specific test you think we should do.

@prcr
Copy link
Contributor

prcr commented Oct 18, 2023

Hi @nicklem and @claudiacarpinteiro. 👋

The reason I had to pin the Markdown version was because at the time there was at least one MkDocs extension that we were using that would break using the newer version, see codacy/pulse-user-docs#122.

It's well possible (and expectable) that all extensions in use are now compatible with newer versions of Markdown. If you don't get any errors during the build process and the generated pages look as expected - such as the ones that use includes, then you should be good to go. 🚀

@nicklem nicklem self-assigned this Oct 18, 2023
@github-actions github-actions bot temporarily deployed to Netlify October 18, 2023 15:47 Inactive
@nicklem nicklem merged commit 677bc13 into master Oct 19, 2023
7 checks passed
@nicklem nicklem deleted the dependabot/pip/markdown-3.5 branch October 19, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants