-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): Bump markdown from 3.3.7 to 3.5 #1884
Conversation
Bumps [markdown](https://github.com/Python-Markdown/markdown) from 3.3.7 to 3.5. - [Changelog](https://github.com/Python-Markdown/markdown/blob/master/docs/changelog.md) - [Commits](Python-Markdown/markdown@3.3.7...3.5) --- updated-dependencies: - dependency-name: markdown dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
We temporarily pinned this to a lower version for a reason unclear to me ATM. We already unpinned the version on the Pulse user docs (codacy/pulse-user-docs#244), but the setup is slightly different there. Before we merge this one, I'd rather double-check to confirm that we're not breaking anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I navigated around and everything looks good to me. 👍
I'm approving it, but let me know if there is any specific test you think we should do.
Hi @nicklem and @claudiacarpinteiro. 👋 The reason I had to pin the Markdown version was because at the time there was at least one MkDocs extension that we were using that would break using the newer version, see codacy/pulse-user-docs#122. It's well possible (and expectable) that all extensions in use are now compatible with newer versions of Markdown. If you don't get any errors during the build process and the generated pages look as expected - such as the ones that use includes, then you should be good to go. 🚀 |
Bumps markdown from 3.3.7 to 3.5.
Changelog
Sourced from markdown's changelog.
... (truncated)
Commits
f50ac47
Refactor changelog6662053
TOC extension: Add new boolean option permalink_prepend (#1339)f99f176
Bump version to 3.4.4ff88261
Unescape backslash escaped TOC token namesd60c16f
Unescape any backslash escaped inline raw HTML93054dd
Fix XML deprecationsdba8025
smarty: Add a special case for 's at the beginning of the token07b8b2c
Use pyspelling to check spelling.c0faf52
Restore console script.6a85e4d
Bump version to 3.4.2Most Recent Ignore Conditions Applied to This Pull Request
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)